On Mon, Feb 22, 2021 at 12:52 AM Jakub Sitnicki [off-list ref] wrote:

On Sat, Feb 20, 2021 at 06:29 AM CET, Cong Wang wrote:

quoted

From: Cong Wang <redacted>

As suggested by John, clean up sockmap related Kconfigs:

Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream
parser, to reflect its name.

Make the rest sockmap code simply depend on CONFIG_BPF_SYSCALL
and CONFIG_INET, the latter is still needed at this point because
of TCP/UDP proto update. And leave CONFIG_NET_SOCK_MSG untouched,
as it is used by non-sockmap cases.

Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Sitnicki <jakub@cloudflare.com>
Reviewed-by: Lorenz Bauer <redacted>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <redacted>
---

Couple comments:

1. sk_psock_done_strp() could be static to skmsg.c, as mentioned
   earlier.

Oops, I thought you meant to move it to sock_map.c...

2. udp_bpf.c is built when CONFIG_BPF_SYSCALL is enabled, while its API
   declarations in udp.h are guarded on CONFIG_NET_SOCK_MSG.

   This works because BPF_SYSCALL now selects NET_SOCK_MSG if INET, and
   INET has to be enabled when using udp, but seems confusing to me.

Sure.

Thanks.