Re: [PATCH bpf-next 2/4] selftests/bpf: expose debug arg to shell script for xsk tests
From: Magnus Karlsson <hidden>
Date: 2021-02-19 13:13:32
Also in:
bpf
On Wed, Feb 17, 2021 at 5:36 PM Ciara Loftus [off-list ref] wrote:
Launching xdpxceiver with -D enables debug mode. Make it possible
Would be clearer if the option was the same both in the shell and in the xdpreceiver app, so please pick -d or -D and stick with it. And how about calling the mode "dump packets" instead of debug, because that is what it is doing right now?
quoted hunk ↗ jump to hunk
to pass this flag to the app via the test_xsk.sh shell script like so: ./test_xsk.sh -d Signed-off-by: Ciara Loftus <redacted> --- tools/testing/selftests/bpf/test_xsk.sh | 7 ++++++- tools/testing/selftests/bpf/xsk_prereqs.sh | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-)diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh index 91127a5be90d..a72f8ed2932d 100755 --- a/tools/testing/selftests/bpf/test_xsk.sh +++ b/tools/testing/selftests/bpf/test_xsk.sh@@ -74,11 +74,12 @@ . xsk_prereqs.sh -while getopts "cv" flag +while getopts "cvd" flag do case "${flag}" in c) colorconsole=1;; v) verbose=1;; + d) debug=1;; esac done@@ -135,6 +136,10 @@ if [[ $verbose -eq 1 ]]; then VERBOSE_ARG="-v" fi +if [[ $debug -eq 1 ]]; then + DEBUG_ARG="-D" +fi + test_status $retval "${TEST_NAME}" ## START TESTSdiff --git a/tools/testing/selftests/bpf/xsk_prereqs.sh b/tools/testing/selftests/bpf/xsk_prereqs.sh index ef8c5b31f4b6..d95018051fcc 100755 --- a/tools/testing/selftests/bpf/xsk_prereqs.sh +++ b/tools/testing/selftests/bpf/xsk_prereqs.sh@@ -128,5 +128,6 @@ execxdpxceiver() copy[$index]=${!current} done - ./${XSKOBJ} -i ${VETH0} -i ${VETH1},${NS1} ${copy[*]} -C ${NUMPKTS} ${VERBOSE_ARG} + ./${XSKOBJ} -i ${VETH0} -i ${VETH1},${NS1} ${copy[*]} -C ${NUMPKTS} ${VERBOSE_ARG} \ + ${DEBUG_ARG} } --2.17.1