Thread (2 messages) flat view 2 messages, 2 authors, 2021-02-11

Re: [PATCH bpf v4] selftests/bpf: convert test_xdp_redirect.sh to bash

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-02-11 15:33:16
Also in: bpf

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

On Thu, 11 Feb 2021 09:20:29 +0100 you wrote:
From: Björn Töpel <redacted>

The test_xdp_redirect.sh script uses a bash feature, '&>'. On systems,
e.g. Debian, where '/bin/sh' is dash, this will not work as
expected. Use bash in the shebang to get the expected behavior.

Further, using 'set -e' means that the error of a command cannot be
captured without the command being executed with '&&' or '||'. Let us
restructure the ping-commands, and use them as an if-expression, so
that we can capture the return value.

[...]
Here is the summary with links:
  - [bpf,v4] selftests/bpf: convert test_xdp_redirect.sh to bash
    https://git.kernel.org/bpf/bpf/c/732fa3233066

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help