Thread (28 messages) 28 messages, 7 authors, 2021-03-10

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

From: Amy Parker <hidden>
Date: 2021-02-06 05:14:10
Also in: bpf, linux-kbuild

On Fri, Feb 5, 2021 at 4:46 AM Jiri Olsa [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The resolve_btfids tool is used during the kernel build,
so we should clean it on kernel's make clean.

Invoking the the resolve_btfids clean as part of root
'make clean'.

Acked-by: Song Liu <redacted>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index b0e4767735dc..159d9592b587 100644
--- a/Makefile
+++ b/Makefile
@@ -1086,6 +1086,11 @@ ifdef CONFIG_STACK_VALIDATION
   endif
 endif

+PHONY += resolve_btfids_clean
+
+resolve_btfids_clean:
+       $(Q)$(MAKE) -sC $(srctree)/tools/bpf/resolve_btfids O=$(abspath $(objtree))/tools/bpf/resolve_btfids clean
+
 ifdef CONFIG_BPF
 ifdef CONFIG_DEBUG_INFO_BTF
   ifeq ($(has_libelf),1)
@@ -1495,7 +1500,7 @@ vmlinuxclean:
        $(Q)$(CONFIG_SHELL) $(srctree)/scripts/link-vmlinux.sh clean
        $(Q)$(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) clean)

-clean: archclean vmlinuxclean
+clean: archclean vmlinuxclean resolve_btfids_clean

 # mrproper - Delete all generated files, including .config
 #
--
2.26.2
It compiles, looks good to me.

Reviewed by: Amy Parker [off-list ref]

Have a great day, and thank you for this patch!

   -Amy IP
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help