Re: [PATCH bpf] selftests/bpf: use bash instead of sh in test_xdp_redirect.sh

On 2/5/21 9:30 AM, William Tu wrote:

On Fri, Feb 5, 2021 at 9:09 AM Björn Töpel [off-list ref] wrote:

quoted

From: Björn Töpel <redacted>

The test_xdp_redirect.sh script uses some bash-features, such as
'&>'. On systems that use dash as the sh implementation this will not
work as intended. Change the shebang to use bash instead.

Hi,
In general we (kernel, maybe not bpf) try to move away from bash to a more
"standard" sh shell, so things like "&>" would be converted to ">file 2>&1"
or whatever is needed.

quoted

Also remove the 'set -e' since the script actually relies on that the
return value can be used to determine pass/fail of the test.

Fixes: 996139e801fd ("selftests: bpf: add a test for XDP redirect")
Signed-off-by: Björn Töpel <redacted>
---

LGTM, thanks.
Acked-by: William Tu <redacted>

-- 
~Randy