Re: [PATCH v3 net-next 08/21] nvme-tcp : Recalculate crc in the end of the capsule

On Wed, Feb 3, 2021 at 11:12 AM Sagi Grimberg [off-list ref] wrote:

quoted

@@ -1841,8 +1913,10 @@ static void __nvme_tcp_stop_queue(struct nvme_tcp_queue *queue)
      nvme_tcp_restore_sock_calls(queue);
      cancel_work_sync(&queue->io_work);

-     if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags))
+     if (test_bit(NVME_TCP_Q_OFF_DDP, &queue->flags) ||
+         test_bit(NVME_TCP_Q_OFF_DDGST_RX, &queue->flags))
              nvme_tcp_unoffload_socket(queue);
+

extra newline

will remove

quoted

  }

  static void nvme_tcp_stop_queue(struct nvme_ctrl *nctrl, int qid)

@@ -1970,8 +2044,6 @@ static int nvme_tcp_alloc_admin_queue(struct nvme_ctrl *ctrl)
  {
      int ret;

-     to_tcp_ctrl(ctrl)->offloading_netdev = NULL;
-

Unclear what is the intent here.

yep, unclear indeed.. will look and probably remove

as for your other comment on this patch, will get back to you later on

quoted

      ret = nvme_tcp_alloc_queue(ctrl, 0, NVME_AQ_DEPTH);
      if (ret)
              return ret;