Re: [PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

On Fri, Feb 26, 2021 at 3:15 PM Cong Wang [off-list ref] wrote:

On Thu, Feb 25, 2021 at 7:59 PM Xuesen Huang [off-list ref] wrote:

quoted

v3:
- Fix the code format.

v2:
Suggested-by: Willem de Bruijn <willemb@google.com>
- Add a new flag to specify the type of the inner packet.

These need to be moved after '---', otherwise it would be merged
into the final git log.

quoted

Suggested-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Xuesen Huang <redacted>
Signed-off-by: Zhiyong Cheng <redacted>
Signed-off-by: Li Wang <redacted>
---
 include/uapi/linux/bpf.h       |  5 +++++
 net/core/filter.c              | 11 ++++++++++-
 tools/include/uapi/linux/bpf.h |  5 +++++
 3 files changed, 20 insertions(+), 1 deletion(-)

As a good practice, please add a test case for this in
tools/testing/selftests/bpf/progs/test_tc_tunnel.c.

That's a great idea. This function covers a lot of cases. Can use the
code coverage against regressions.

With that caveat, looks great to me, thanks.