Thread (4 messages) 4 messages, 3 authors, 2021-02-26

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

flat view

From: Richard Cochran <richardcochran@gmail.com>
Date: 2021-02-26 15:24:27
Also in: lkml

On Thu, Feb 25, 2021 at 10:15:16PM +0100, Heiko Thiery wrote:
When accessing the timecounter register on an i.MX8MQ the kernel hangs.
This is only the case when the interface is down. This can be reproduced
by reading with 'phc_ctrl eth0 get'.

Like described in the change in 91c0d987a9788dcc5fe26baafd73bf9242b68900
the igp clock is disabled when the interface is down and leads to a
system hang.

So we check if the ptp clock status before reading the timecounter
register.

Signed-off-by: Heiko Thiery <redacted>
---
v2:
 - add mutex (thanks to Richard)

v3:
I did a mistake and did not test properly
 - add parenteses
 - fix the used variable
Acked-by: Richard Cochran <richardcochran@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help