Re: [PATCH] libbpf: Remove unnecessary conversion to bool
From: Andrii Nakryiko <hidden>
Date: 2021-02-23 01:50:44
Also in:
bpf, lkml
On Sat, Feb 20, 2021 at 1:11 AM Jiapeng Chong [off-list ref] wrote:
Fix the following coccicheck warnings: ./tools/lib/bpf/libbpf.c:1487:43-48: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> ---
I think this came up before already. I did this on purpose and I'd like to keep it that way in the code.
quoted hunk ↗ jump to hunk
tools/lib/bpf/libbpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 6ae748f..5dfdbf3 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c@@ -1484,7 +1484,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val, ext->name, value); return -EINVAL; } - *(bool *)ext_val = value == 'y' ? true : false; + *(bool *)ext_val = value == 'y'; break; case KCFG_TRISTATE: if (value == 'y') --1.8.3.1