This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
Arseny Krasnov (19):
af_vsock: update functions for connectible socket
af_vsock: separate wait data loop
af_vsock: separate receive data loop
af_vsock: implement SEQPACKET receive loop
af_vsock: separate wait space loop
af_vsock: implement send logic for SEQPACKET
af_vsock: rest of SEQPACKET support
af_vsock: update comments for stream sockets
virtio/vsock: set packet's type in send
virtio/vsock: simplify credit update function API
virtio/vsock: dequeue callback for SOCK_SEQPACKET
virtio/vsock: fetch length for SEQPACKET record
virtio/vsock: add SEQPACKET receive logic
virtio/vsock: rest of SOCK_SEQPACKET support
virtio/vsock: setup SEQPACKET ops for transport
vhost/vsock: setup SEQPACKET ops for transport
vsock/loopback: setup SEQPACKET ops for transport
vsock_test: add SOCK_SEQPACKET tests
virtio/vsock: update trace event for SEQPACKET
drivers/vhost/vsock.c | 8 +-
include/linux/virtio_vsock.h | 14 +
include/net/af_vsock.h | 9 +
.../events/vsock_virtio_transport_common.h | 48 +-
include/uapi/linux/virtio_vsock.h | 16 +
net/vmw_vsock/af_vsock.c | 590 +++++++++++------
net/vmw_vsock/virtio_transport.c | 5 +
net/vmw_vsock/virtio_transport_common.c | 342 ++++++++--
net/vmw_vsock/vsock_loopback.c | 5 +
tools/testing/vsock/util.c | 32 +-
tools/testing/vsock/util.h | 3 +
tools/testing/vsock/vsock_test.c | 126 ++++
12 files changed, 951 insertions(+), 247 deletions(-)
v4 -> v5:
- patches reorganized:
1) Setting of packet's type in 'virtio_transport_send_pkt_info()'
is moved to separate patch.
2) Simplifying of 'virtio_transport_send_credit_update()' is
moved to separate patch and before main virtio/vsock patches.
- style problem fixed
- in 'af_vsock: separate receive data loop' extra 'release_sock()'
removed
- added trace event fields for SEQPACKET
- in 'af_vsock: separate wait data loop':
1) 'vsock_wait_data()' removed 'goto out;'
2) Comment for invalid data amount is changed.
- in 'af_vsock: rest of SEQPACKET support', 'new_transport' pointer
check is moved after 'try_module_get()'
- in 'af_vsock: update comments for stream sockets', 'connect-oriented'
replaced with 'connection-oriented'
- in 'loopback/vsock: setup SEQPACKET ops for transport',
'loopback/vsock' replaced with 'vsock/loopback'
v3 -> v4:
- SEQPACKET specific metadata moved from packet header to payload
and called 'virtio_vsock_seq_hdr'
- record integrity check:
1) SEQ_END operation was added, which marks end of record.
2) Both SEQ_BEGIN and SEQ_END carries counter which is incremented
on every marker send.
- af_vsock.c: socket operations for STREAM and SEQPACKET call same
functions instead of having own "gates" differs only by names:
'vsock_seqpacket/stream_getsockopt()' now replaced with
'vsock_connectible_getsockopt()'.
- af_vsock.c: 'seqpacket_dequeue' callback returns error and flag that
record ready. There is no need to return number of copied bytes,
because case when record received successfully is checked at virtio
transport layer, when SEQ_END is processed. Also user doesn't need
number of copied bytes, because 'recv()' from SEQPACKET could return
error, length of users's buffer or length of whole record(both are
known in af_vsock.c).
- af_vsock.c: both wait loops in af_vsock.c(for data and space) moved
to separate functions because now both called from several places.
- af_vsock.c: 'vsock_assign_transport()' checks that 'new_transport'
pointer is not NULL and returns 'ESOCKTNOSUPPORT' instead of 'ENODEV'
if failed to use transport.
- tools/testing/vsock/vsock_test.c: rename tests
v2 -> v3:
- patches reorganized: split for prepare and implementation patches
- local variables are declared in "Reverse Christmas tree" manner
- virtio_transport_common.c: valid leXX_to_cpu() for vsock header
fields access
- af_vsock.c: 'vsock_connectible_*sockopt()' added as shared code
between stream and seqpacket sockets.
- af_vsock.c: loops in '__vsock_*_recvmsg()' refactored.
- af_vsock.c: 'vsock_wait_data()' refactored.
v1 -> v2:
- patches reordered: af_vsock.c related changes now before virtio vsock
- patches reorganized: more small patches, where +/- are not mixed
- tests for SOCK_SEQPACKET added
- all commit messages updated
- af_vsock.c: 'vsock_pre_recv_check()' inlined to
'vsock_connectible_recvmsg()'
- af_vsock.c: 'vsock_assign_transport()' returns ENODEV if transport
was not found
- virtio_transport_common.c: transport callback for seqpacket dequeue
- virtio_transport_common.c: simplified
'virtio_transport_recv_connected()'
- virtio_transport_common.c: send reset on socket and packet type
mismatch.
Signed-off-by: Arseny Krasnov <redacted>
--
2.25.1
This moves wait loop for data to dedicated function, because later
it will be used by SEQPACKET data receive loop.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 155 +++++++++++++++++++++------------------
1 file changed, 83 insertions(+), 72 deletions(-)
@@ -1832,6 +1832,68 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,returnerr;}+staticintvsock_wait_data(structsock*sk,structwait_queue_entry*wait,+longtimeout,+structvsock_transport_recv_notify_data*recv_data,+size_ttarget)+{+conststructvsock_transport*transport;+structvsock_sock*vsk;+s64data;+interr;++vsk=vsock_sk(sk);+err=0;+transport=vsk->transport;+prepare_to_wait(sk_sleep(sk),wait,TASK_INTERRUPTIBLE);++while((data=vsock_stream_has_data(vsk))==0){+if(sk->sk_err!=0||+(sk->sk_shutdown&RCV_SHUTDOWN)||+(vsk->peer_shutdown&SEND_SHUTDOWN)){+break;+}++/* Don't wait for non-blocking sockets. */+if(timeout==0){+err=-EAGAIN;+break;+}++if(recv_data){+err=transport->notify_recv_pre_block(vsk,target,recv_data);+if(err<0)+break;+}++release_sock(sk);+timeout=schedule_timeout(timeout);+lock_sock(sk);++if(signal_pending(current)){+err=sock_intr_errno(timeout);+break;+}elseif(timeout==0){+err=-EAGAIN;+break;+}+}++finish_wait(sk_sleep(sk),wait);++if(err)+returnerr;++/* Internal transport error when checking for available+*data.XXXThisshouldbechangedtoaconnection+*resetinalaterchange.+*/+if(data<0)+return-ENOMEM;++returndata;+}+staticintvsock_connectible_recvmsg(structsocket*sock,structmsghdr*msg,size_tlen,intflags)
This prepares af_vsock.c for SEQPACKET support: some functions such
as setsockopt(), getsockopt(), connect(), recvmsg(), sendmsg() are
shared between both types of sockets, so rename them in general
manner.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 64 +++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 30 deletions(-)
This moves STREAM specific data receive logic to dedicated function:
'__vsock_stream_recvmsg()', while checks that will be same for both
types of socket are in shared function: 'vsock_connectible_recvmsg()'.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 116 ++++++++++++++++++++++-----------------
1 file changed, 67 insertions(+), 49 deletions(-)
@@ -1894,65 +1894,22 @@ static int vsock_wait_data(struct sock *sk, struct wait_queue_entry *wait,returndata;}-staticint-vsock_connectible_recvmsg(structsocket*sock,structmsghdr*msg,size_tlen,-intflags)+staticint__vsock_stream_recvmsg(structsock*sk,structmsghdr*msg,+size_tlen,intflags){-structsock*sk;-structvsock_sock*vsk;+structvsock_transport_recv_notify_datarecv_data;conststructvsock_transport*transport;-interr;-size_ttarget;+structvsock_sock*vsk;ssize_tcopied;+size_ttarget;longtimeout;-structvsock_transport_recv_notify_datarecv_data;+interr;DEFINE_WAIT(wait);-sk=sock->sk;vsk=vsock_sk(sk);-err=0;--lock_sock(sk);-transport=vsk->transport;-if(!transport||sk->sk_state!=TCP_ESTABLISHED){-/* Recvmsg is supposed to return 0 if a peer performs an-*orderlyshutdown.Differentiatebetweenthatcaseandwhena-*peerhasnotconnectedoralocalshutdownoccuredwiththe-*SOCK_DONEflag.-*/-if(sock_flag(sk,SOCK_DONE))-err=0;-else-err=-ENOTCONN;--gotoout;-}--if(flags&MSG_OOB){-err=-EOPNOTSUPP;-gotoout;-}--/* We don't check peer_shutdown flag here since peer may actually shut-*down,buttherecanbedatainthequeuethatalocalsocketcan-*receive.-*/-if(sk->sk_shutdown&RCV_SHUTDOWN){-err=0;-gotoout;-}--/* It is valid on Linux to pass in a zero-length receive buffer. This-*isnotanerror.Wemayaswellbailoutnow.-*/-if(!len){-err=0;-gotoout;-}-/* We must not copy less than target bytes into the user's buffer*beforereturningsuccessfully,sowewaitfortheconsumequeueto*havethatmuchdatatoconsumebeforedequeueing.Notethatthis
@@ -2011,6 +1968,67 @@ vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,if(copied>0)err=copied;+out:+returnerr;+}++staticint+vsock_connectible_recvmsg(structsocket*sock,structmsghdr*msg,size_tlen,+intflags)+{+structsock*sk;+structvsock_sock*vsk;+conststructvsock_transport*transport;+interr;++DEFINE_WAIT(wait);++sk=sock->sk;+vsk=vsock_sk(sk);+err=0;++lock_sock(sk);++transport=vsk->transport;++if(!transport||sk->sk_state!=TCP_ESTABLISHED){+/* Recvmsg is supposed to return 0 if a peer performs an+*orderlyshutdown.Differentiatebetweenthatcaseandwhena+*peerhasnotconnectedoralocalshutdownoccurredwiththe+*SOCK_DONEflag.+*/+if(sock_flag(sk,SOCK_DONE))+err=0;+else+err=-ENOTCONN;++gotoout;+}++if(flags&MSG_OOB){+err=-EOPNOTSUPP;+gotoout;+}++/* We don't check peer_shutdown flag here since peer may actually shut+*down,buttherecanbedatainthequeuethatalocalsocketcan+*receive.+*/+if(sk->sk_shutdown&RCV_SHUTDOWN){+err=0;+gotoout;+}++/* It is valid on Linux to pass in a zero-length receive buffer. This+*isnotanerror.Wemayaswellbailoutnow.+*/+if(!len){+err=0;+gotoout;+}++err=__vsock_stream_recvmsg(sk,msg,len,flags);+out:release_sock(sk);returnerr;
This moves loop that waits for space on send to separate function,
because it will be used for SEQ_BEGIN/SEQ_END sending before and
after data transmission. Waiting for SEQ_BEGIN/SEQ_END is needed
because such packets carries SEQPACKET header that couldn't be
fragmented by credit mechanism, so to avoid it, sender waits until
enough space will be ready.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 2 +
net/vmw_vsock/af_vsock.c | 99 +++++++++++++++++++++++++---------------
2 files changed, 63 insertions(+), 38 deletions(-)
@@ -1740,9 +1797,6 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,gotoout;}-/* Wait for room in the produce queue to enqueue our user's data. */-timeout=sock_sndtimeo(sk,msg->msg_flags&MSG_DONTWAIT);-err=transport->notify_send_init(vsk,&send_data);if(err<0)gotoout;
@@ -1750,39 +1804,8 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,while(total_written<len){ssize_twritten;-add_wait_queue(sk_sleep(sk),&wait);-while(vsock_stream_has_space(vsk)==0&&-sk->sk_err==0&&-!(sk->sk_shutdown&SEND_SHUTDOWN)&&-!(vsk->peer_shutdown&RCV_SHUTDOWN)){--/* Don't wait for non-blocking sockets. */-if(timeout==0){-err=-EAGAIN;-remove_wait_queue(sk_sleep(sk),&wait);-gotoout_err;-}--err=transport->notify_send_pre_block(vsk,&send_data);-if(err<0){-remove_wait_queue(sk_sleep(sk),&wait);-gotoout_err;-}--release_sock(sk);-timeout=wait_woken(&wait,TASK_INTERRUPTIBLE,timeout);-lock_sock(sk);-if(signal_pending(current)){-err=sock_intr_errno(timeout);-remove_wait_queue(sk_sleep(sk),&wait);-gotoout_err;-}elseif(timeout==0){-err=-EAGAIN;-remove_wait_queue(sk_sleep(sk),&wait);-gotoout_err;-}-}-remove_wait_queue(sk_sleep(sk),&wait);+if(vsock_wait_space(sk,1,msg->msg_flags,&send_data))+gotoout_err;/* These checks occur both as part of and after the loop*conditionalsinceweneedtocheckbeforeandafter
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there is no sense for these values in SEQPACKET case.
3) It waits until whole record is received or error is found during
receiving.
4) It processes and sets 'MSG_TRUNC' flag.
So to avoid extra conditions for two types of socket inside one loop, two
independent functions were created.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 5 +++
net/vmw_vsock/af_vsock.c | 97 +++++++++++++++++++++++++++++++++++++++-
2 files changed, 101 insertions(+), 1 deletion(-)
@@ -1972,6 +1972,98 @@ static int __vsock_stream_recvmsg(struct sock *sk, struct msghdr *msg,returnerr;}+staticint__vsock_seqpacket_recvmsg(structsock*sk,structmsghdr*msg,+size_tlen,intflags)+{+conststructvsock_transport*transport;+conststructiovec*orig_iov;+unsignedlongorig_nr_segs;+boolmsg_ready;+structvsock_sock*vsk;+size_trecord_len;+longtimeout;+interr=0;+DEFINE_WAIT(wait);++vsk=vsock_sk(sk);+transport=vsk->transport;++timeout=sock_rcvtimeo(sk,flags&MSG_DONTWAIT);+orig_nr_segs=msg->msg_iter.nr_segs;+orig_iov=msg->msg_iter.iov;+msg_ready=false;+record_len=0;++while(1){+err=vsock_wait_data(sk,&wait,timeout,NULL,0);++if(err<=0){+/* In case of any loop break(timeout, signal+*interruptorshutdown),wereportuserthat+*nothingwascopied.+*/+err=0;+break;+}++if(record_len==0){+record_len=+transport->seqpacket_seq_get_len(vsk);++if(record_len==0)+continue;+}++err=transport->seqpacket_dequeue(vsk,msg,+flags,&msg_ready);++if(err<0){+if(err==-EAGAIN){+iov_iter_init(&msg->msg_iter,READ,+orig_iov,orig_nr_segs,+len);+/* Clear 'MSG_EOR' here, because dequeue+*callbackabovesetitagainifitwas+*setbysender.This'MSG_EOR'isfrom+*droppedrecord.+*/+msg->msg_flags&=~MSG_EOR;+record_len=0;+continue;+}++err=-ENOMEM;+break;+}++if(msg_ready)+break;+}++if(sk->sk_err)+err=-sk->sk_err;+elseif(sk->sk_shutdown&RCV_SHUTDOWN)+err=0;++if(msg_ready){+/* User sets MSG_TRUNC, so return real length of+*packet.+*/+if(flags&MSG_TRUNC)+err=record_len;+else+err=len-msg->msg_iter.count;++/* Always set MSG_TRUNC if real length of packet is+*biggerthanuser'sbuffer.+*/+if(record_len>len)+msg->msg_flags|=MSG_TRUNC;+}++returnerr;+}+staticintvsock_connectible_recvmsg(structsocket*sock,structmsghdr*msg,size_tlen,intflags)
This adds some logic to current stream enqueue function for SEQPACKET
support:
1) Send record's begin/end marker.
2) Return value from enqueue function is whole record length or error
for SOCK_SEQPACKET.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 2 ++
net/vmw_vsock/af_vsock.c | 22 ++++++++++++++++++++--
2 files changed, 22 insertions(+), 2 deletions(-)
@@ -1847,9 +1853,21 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,}+if(sk->sk_type==SOCK_SEQPACKET){+err=transport->seqpacket_seq_send_eor(vsk,msg->msg_flags);+if(err<0)+gotoout;+}+out_err:-if(total_written>0)-err=total_written;+if(total_written>0){+/* Return number of written bytes only if:+*1)SOCK_STREAMsocket.+*2)SOCK_SEQPACKETsocketwhenwholebufferissent.+*/+if(sk->sk_type==SOCK_STREAM||total_written==len)+err=total_written;+}out:release_sock(sk);returnerr;
This replaces 'stream' to 'connect oriented' in comments as SEQPACKET is
also connect oriented.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 31 +++++++++++++++++--------------
1 file changed, 17 insertions(+), 14 deletions(-)
@@ -415,8 +415,8 @@ static void vsock_deassign_transport(struct vsock_sock *vsk)/* Assign a transport to a socket and call the .init transport callback.*-*Note:forstreamsocketthismustbecalledwhenvsk->remote_addrisset-*(e.g.duringtheconnect()orwhenaconnectionrequestonalistener+*Note:forconnectionorientedsocketthismustbecalledwhenvsk->remote_addr+*isset(e.g.duringtheconnect()orwhenaconnectionrequestonalistener*socketisreceived).*Thevsk->remote_addrisusedtodecidewhichtransporttouse:*-remoteCID==VMADDR_CID_LOCALorg2h->local_cidorVMADDR_CID_HOSTif
@@ -470,10 +470,10 @@ int vsock_assign_transport(struct vsock_sock *vsk, struct vsock_sock *psk)return0;/* transport->release() must be called with sock lock acquired.-*Thispathcanonlybetakenduringvsock_stream_connect(),-*wherewehavealreadyheldthesocklock.-*Intheothercases,thisfunctioniscalledonanewsocket-*whichisnotassignedtoanytransport.+*Thispathcanonlybetakenduringvsock_connect(),wherewe+*havealreadyheldthesocklock.Intheothercases,this+*functioniscalledonanewsocketwhichisnotassignedto+*anytransport.*/vsk->transport->release(vsk);vsock_deassign_transport(vsk);
@@ -658,9 +658,10 @@ static int __vsock_bind_connectible(struct vsock_sock *vsk,vsock_addr_init(&vsk->local_addr,new_addr.svm_cid,new_addr.svm_port);-/* Remove stream sockets from the unbound list and add them to the hash-*tableforeasylookupbyitsaddress.Theunboundlistissimplyan-*extraentryattheendofthehashtable,atrickusedbyAF_UNIX.+/* Remove connection oriented sockets from the unbound list and add them+*tothehashtableforeasylookupbyitsaddress.Theunboundlist+*issimplyanextraentryattheendofthehashtable,atrickused+*byAF_UNIX.*/__vsock_remove_bound(vsk);__vsock_insert_bound(vsock_bound_sockets(&vsk->local_addr),vsk);
@@ -951,10 +952,10 @@ static int vsock_shutdown(struct socket *sock, int mode)if((mode&~SHUTDOWN_MASK)||!mode)return-EINVAL;-/* If this is a STREAM socket and it is not connected then bail out-*immediately.IfitisaDGRAMsocketthenwemustfirstkickthe-*socketsothatitwakesupfromanysleepingcalls,forexample-*recv(),andthenafterwardsreturntheerror.+/* If this is a connection oriented socket and it is not connected then+*bailoutimmediately.IfitisaDGRAMsocketthenwemustfirst+*kickthesocketsothatitwakesupfromanysleepingcalls,for+*examplerecv(),andthenafterwardsreturntheerror.*/sk=sock->sk;
@@ -1783,7 +1784,9 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,transport=vsk->transport;-/* Callers should not provide a destination with stream sockets. */+/* Callers should not provide a destination with connection oriented+*sockets.+*/if(msg->msg_namelen){err=sk->sk_state==TCP_ESTABLISHED?-EISCONN:-EOPNOTSUPP;gotoout;
'virtio_transport_send_credit_update()' has some extra args:
1) 'type' may be set in 'virtio_transport_send_pkt_info()' using type
of socket.
2) This function is static and 'hdr' arg was always NULL.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/virtio_transport_common.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
This moves passing type of packet from 'info' srtucture to send
function. There is no sense to set type of packet which differs
from type of socket, and since at current time only stream type
is supported, so force to use this type.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/virtio_transport_common.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
@@ -179,6 +179,8 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,structvirtio_vsock_pkt*pkt;u32pkt_len=info->pkt_len;+info->type=VIRTIO_VSOCK_TYPE_STREAM;+t_ops=virtio_transport_get_ops(vsk);if(unlikely(!t_ops))return-EFAULT;
@@ -624,7 +626,6 @@ int virtio_transport_connect(struct vsock_sock *vsk){structvirtio_vsock_pkt_infoinfo={.op=VIRTIO_VSOCK_OP_REQUEST,-.type=VIRTIO_VSOCK_TYPE_STREAM,.vsk=vsk,};
@@ -636,7 +637,6 @@ int virtio_transport_shutdown(struct vsock_sock *vsk, int mode){structvirtio_vsock_pkt_infoinfo={.op=VIRTIO_VSOCK_OP_SHUTDOWN,-.type=VIRTIO_VSOCK_TYPE_STREAM,.flags=(mode&RCV_SHUTDOWN?VIRTIO_VSOCK_SHUTDOWN_RCV:0)|(mode&SEND_SHUTDOWN?
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
@@ -83,6 +89,11 @@ enum virtio_vsock_op {VIRTIO_VSOCK_OP_CREDIT_UPDATE=6,/* Request the peer to send the credit info to us */VIRTIO_VSOCK_OP_CREDIT_REQUEST=7,++/* Record begin for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_BEGIN=8,+/* Record end for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_END=9,};/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
@@ -393,6 +393,108 @@ virtio_transport_stream_do_dequeue(struct vsock_sock *vsk,returnerr;}+staticinlinevoidvirtio_transport_remove_pkt(structvirtio_vsock_pkt*pkt)+{+list_del(&pkt->list);+virtio_transport_free_pkt(pkt);+}++staticintvirtio_transport_seqpacket_do_dequeue(structvsock_sock*vsk,+structmsghdr*msg,+bool*msg_ready)+{+structvirtio_vsock_sock*vvs=vsk->trans;+structvirtio_vsock_pkt*pkt;+interr=0;+size_tuser_buf_len=msg->msg_iter.count;++*msg_ready=false;+spin_lock_bh(&vvs->rx_lock);++while(!*msg_ready&&!list_empty(&vvs->rx_queue)&&!err){+pkt=list_first_entry(&vvs->rx_queue,structvirtio_vsock_pkt,list);++switch(le16_to_cpu(pkt->hdr.op)){+caseVIRTIO_VSOCK_OP_SEQ_BEGIN:{+/* Unexpected 'SEQ_BEGIN' during record copy:+*Leavereceiveloop,'EAGAIN'willrestartitfrom+*outerreceiveloop,packetisstillinqueueand+*countersarecleared.Soinnextloopenter,+*'SEQ_BEGIN'willbedequeuedfirst.User'siov+*iteratorwillberesetinouterloop.Also+*sendcreditupdate,becausesomebytescouldbe+*copied.Userwillneverseeunfinishedrecord.+*/+err=-EAGAIN;+break;+}+caseVIRTIO_VSOCK_OP_SEQ_END:{+structvirtio_vsock_seq_hdr*seq_hdr;++seq_hdr=(structvirtio_vsock_seq_hdr*)pkt->buf;+/* First check that whole record is received. */++if(vvs->user_read_copied!=vvs->user_read_seq_len||+(le32_to_cpu(seq_hdr->msg_cnt)-vvs->curr_rx_msg_cnt)!=1){+/* Tail of current record and head of next missed,+*sothisEORisfromnextrecord.Restartreceive.+*Currentrecordwillbedropped,nextheadlesswill+*bedroppedonnextattempttogetrecordlength.+*/+err=-EAGAIN;+}else{+/* Success. */+*msg_ready=true;+}++break;+}+caseVIRTIO_VSOCK_OP_RW:{+size_tbytes_to_copy;+size_tpkt_len;++pkt_len=(size_t)le32_to_cpu(pkt->hdr.len);+bytes_to_copy=min(user_buf_len,pkt_len);++/* sk_lock is held by caller so no one else can dequeue.+*Unlockrx_locksincememcpy_to_msg()maysleep.+*/+spin_unlock_bh(&vvs->rx_lock);++if(memcpy_to_msg(msg,pkt->buf,bytes_to_copy)){+spin_lock_bh(&vvs->rx_lock);+err=-EINVAL;+break;+}++spin_lock_bh(&vvs->rx_lock);+user_buf_len-=bytes_to_copy;+vvs->user_read_copied+=pkt_len;++if(le32_to_cpu(pkt->hdr.flags)&VIRTIO_VSOCK_RW_EOR)+msg->msg_flags|=MSG_EOR;+break;+}+default:+;+}++/* For unexpected 'SEQ_BEGIN', keep such packet in queue,+*butdropanyothertypeofpacket.+*/+if(le16_to_cpu(pkt->hdr.op)!=VIRTIO_VSOCK_OP_SEQ_BEGIN){+virtio_transport_dec_rx_pkt(vvs,pkt);+virtio_transport_remove_pkt(pkt);+}+}++spin_unlock_bh(&vvs->rx_lock);++virtio_transport_send_credit_update(vsk);++returnerr;+}+ssize_tvirtio_transport_stream_dequeue(structvsock_sock*vsk,structmsghdr*msg,
This adds rest of logic for SEQPACKET:
1) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END.
Note that both functions may sleep to wait enough space for
SEQPACKET header.
2) SEQ_BEGIN/SEQ_END in TAP packet capture.
3) Send SHUTDOWN on socket close for SEQPACKET type.
4) Set SEQPACKET packet type during send.
5) Set MSG_EOR in flags for SEQPACKET during send.
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 3 ++
net/vmw_vsock/virtio_transport_common.c | 67 ++++++++++++++++++++++++-
2 files changed, 68 insertions(+), 2 deletions(-)
@@ -187,7 +189,12 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,structvirtio_vsock_pkt*pkt;u32pkt_len=info->pkt_len;-info->type=VIRTIO_VSOCK_TYPE_STREAM;+info->type=virtio_transport_get_type(sk_vsock(vsk));++if(info->type==VIRTIO_VSOCK_TYPE_SEQPACKET&&+info->msg&&+info->msg->msg_flags&MSG_EOR)+info->flags|=VIRTIO_VSOCK_RW_EOR;t_ops=virtio_transport_get_ops(vsk);if(unlikely(!t_ops))
@@ -401,6 +408,62 @@ virtio_transport_stream_do_dequeue(struct vsock_sock *vsk,returnerr;}+staticintvirtio_transport_seqpacket_send_ctrl(structvsock_sock*vsk,+inttype,+size_tlen,+intflags)+{+structvirtio_vsock_sock*vvs=vsk->trans;+structvirtio_vsock_pkt_infoinfo={+.op=type,+.vsk=vsk,+.pkt_len=sizeof(structvirtio_vsock_seq_hdr)+};++structvirtio_vsock_seq_hdrseq_hdr={+.msg_cnt=cpu_to_le32(vvs->next_tx_msg_cnt),+.msg_len=cpu_to_le32(len)+};++structkvecseq_hdr_kiov={+.iov_base=(void*)&seq_hdr,+.iov_len=sizeof(structvirtio_vsock_seq_hdr)+};++structmsghdrmsg={0};++//XXX: do we need 'vsock_transport_send_notify_data' pointer?+if(vsock_wait_space(sk_vsock(vsk),+sizeof(structvirtio_vsock_seq_hdr),+flags,NULL))+return-1;++iov_iter_kvec(&msg.msg_iter,WRITE,&seq_hdr_kiov,1,sizeof(seq_hdr));++info.msg=&msg;+vvs->next_tx_msg_cnt++;++returnvirtio_transport_send_pkt_info(vsk,&info);+}++intvirtio_transport_seqpacket_seq_send_len(structvsock_sock*vsk,size_tlen,intflags)+{+returnvirtio_transport_seqpacket_send_ctrl(vsk,+VIRTIO_VSOCK_OP_SEQ_BEGIN,+len,+flags);+}+EXPORT_SYMBOL_GPL(virtio_transport_seqpacket_seq_send_len);++intvirtio_transport_seqpacket_seq_send_eor(structvsock_sock*vsk,intflags)+{+returnvirtio_transport_seqpacket_send_ctrl(vsk,+VIRTIO_VSOCK_OP_SEQ_END,+0,+flags);+}+EXPORT_SYMBOL_GPL(virtio_transport_seqpacket_seq_send_eor);+staticinlinevoidvirtio_transport_remove_pkt(structvirtio_vsock_pkt*pkt){list_del(&pkt->list);
This adds transport callback which tries to fetch record begin marker
from socket's rx queue. It is called from af_vsock.c before reading data
packets of record.
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 1 +
net/vmw_vsock/virtio_transport_common.c | 53 +++++++++++++++++++++++++
2 files changed, 54 insertions(+)
This modifies current receive logic for SEQPACKET support:
1) Inserts 'SEQ_BEGIN' packet to socket's rx queue.
2) Inserts 'RW' packet to socket's rx queue, but without merging with
buffer of last packet in queue.
3) Performs check for packet and socket types on receive(if mismatch,
then reset connection).
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/virtio_transport_common.c | 63 +++++++++++++++++--------
1 file changed, 44 insertions(+), 19 deletions(-)
@@ -165,6 +165,14 @@ void virtio_transport_deliver_tap_pkt(struct virtio_vsock_pkt *pkt)}EXPORT_SYMBOL_GPL(virtio_transport_deliver_tap_pkt);+staticu16virtio_transport_get_type(structsock*sk)+{+if(sk->sk_type==SOCK_STREAM)+returnVIRTIO_VSOCK_TYPE_STREAM;+else+returnVIRTIO_VSOCK_TYPE_SEQPACKET;+}+/* This function can only be used on connecting/connected sockets,*sinceasocketassignedtoatransportisrequired.*
@@ -1060,25 +1068,27 @@ virtio_transport_recv_enqueue(struct vsock_sock *vsk,gotoout;}-/* Try to copy small packets into the buffer of last packet queued,-*toavoidwastingmemoryqueueingtheentirebufferwithasmall-*payload.-*/-if(pkt->len<=GOOD_COPY_LEN&&!list_empty(&vvs->rx_queue)){-structvirtio_vsock_pkt*last_pkt;+if(le16_to_cpu(pkt->hdr.type)==VIRTIO_VSOCK_TYPE_STREAM){+/* Try to copy small packets into the buffer of last packet queued,+*toavoidwastingmemoryqueueingtheentirebufferwithasmall+*payload.+*/+if(pkt->len<=GOOD_COPY_LEN&&!list_empty(&vvs->rx_queue)){+structvirtio_vsock_pkt*last_pkt;-last_pkt=list_last_entry(&vvs->rx_queue,-structvirtio_vsock_pkt,list);+last_pkt=list_last_entry(&vvs->rx_queue,+structvirtio_vsock_pkt,list);-/* If there is space in the last packet queued, we copy the-*newpacketinitsbuffer.-*/-if(pkt->len<=last_pkt->buf_len-last_pkt->len){-memcpy(last_pkt->buf+last_pkt->len,pkt->buf,-pkt->len);-last_pkt->len+=pkt->len;-free_pkt=true;-gotoout;+/* If there is space in the last packet queued, we copy the+*newpacketinitsbuffer.+*/+if(pkt->len<=last_pkt->buf_len-last_pkt->len){+memcpy(last_pkt->buf+last_pkt->len,pkt->buf,+pkt->len);+last_pkt->len+=pkt->len;+free_pkt=true;+gotoout;+}}}
@@ -1243,6 +1257,12 @@ virtio_transport_recv_listen(struct sock *sk, struct virtio_vsock_pkt *pkt,return0;}+staticboolvirtio_transport_valid_type(u16type)+{+return(type==VIRTIO_VSOCK_TYPE_STREAM)||+(type==VIRTIO_VSOCK_TYPE_SEQPACKET);+}+/* We are under the virtio-vsock's vsock->rx_lock or vhost-vsock's vq->mutex*lock.*/
This also removes ignore of non-stream type of packets.
Signed-off-by: Arseny Krasnov <redacted>
---
drivers/vhost/vsock.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
This adds two tests of SOCK_SEQPACKET socket: both transfer data and
then test MSG_EOR and MSG_TRUNC flags. Cases for connect(), bind(),
etc. are not tested, because it is same as for stream socket.
Signed-off-by: Arseny Krasnov <redacted>
---
tools/testing/vsock/util.c | 32 ++++++--
tools/testing/vsock/util.h | 3 +
tools/testing/vsock/vsock_test.c | 126 +++++++++++++++++++++++++++++++
3 files changed, 156 insertions(+), 5 deletions(-)
@@ -84,7 +84,7 @@ void vsock_wait_remote_close(int fd)}/* Connect to <cid, port> and return the file descriptor. */-intvsock_stream_connect(unsignedintcid,unsignedintport)+staticintvsock_connect(unsignedintcid,unsignedintport,inttype){union{structsockaddrsa;
@@ -101,7 +101,7 @@ int vsock_stream_connect(unsigned int cid, unsigned int port)control_expectln("LISTENING");-fd=socket(AF_VSOCK,SOCK_STREAM,0);+fd=socket(AF_VSOCK,type,0);timeout_begin(TIMEOUT);do{
@@ -120,11 +120,21 @@ int vsock_stream_connect(unsigned int cid, unsigned int port)returnfd;}+intvsock_stream_connect(unsignedintcid,unsignedintport)+{+returnvsock_connect(cid,port,SOCK_STREAM);+}++intvsock_seqpacket_connect(unsignedintcid,unsignedintport)+{+returnvsock_connect(cid,port,SOCK_SEQPACKET);+}+/* Listen on <cid, port> and return the first incoming connection. The remote*addressisstoredtoclientaddrp.clientaddrpmaybeNULL.*/-intvsock_stream_accept(unsignedintcid,unsignedintport,-structsockaddr_vm*clientaddrp)+staticintvsock_accept(unsignedintcid,unsignedintport,+structsockaddr_vm*clientaddrp,inttype){union{structsockaddrsa;
@@ -145,7 +155,7 @@ int vsock_stream_accept(unsigned int cid, unsigned int port,intclient_fd;intold_errno;-fd=socket(AF_VSOCK,SOCK_STREAM,0);+fd=socket(AF_VSOCK,type,0);if(bind(fd,&addr.sa,sizeof(addr.svm))<0){perror("bind");
@@ -189,6 +199,18 @@ int vsock_stream_accept(unsigned int cid, unsigned int port,returnclient_fd;}+intvsock_stream_accept(unsignedintcid,unsignedintport,+structsockaddr_vm*clientaddrp)+{+returnvsock_accept(cid,port,clientaddrp,SOCK_STREAM);+}++intvsock_seqpacket_accept(unsignedintcid,unsignedintport,+structsockaddr_vm*clientaddrp)+{+returnvsock_accept(cid,port,clientaddrp,SOCK_SEQPACKET);+}+/* Transmit one byte and check the return value.**expected_ret:
On Thu, Feb 18, 2021 at 08:36:03AM +0300, Arseny Krasnov wrote:
This prepares af_vsock.c for SEQPACKET support: some functions such
as setsockopt(), getsockopt(), connect(), recvmsg(), sendmsg() are
shared between both types of sockets, so rename them in general
manner.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 64 +++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 30 deletions(-)
IIRC I had already given my R-b to this patch. Please carry it over when
you post a new version.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
if (vsk->transport)
vsk->transport->release(vsk);
- else if (sk->sk_type == SOCK_STREAM)
+ else if (sock_type_connectible(sk->sk_type))
vsock_remove_sock(vsk);
sock_orphan(sk);
@@ -947,7 +952,7 @@ static int vsock_shutdown(struct socket *sock, int mode)
lock_sock(sk);
if (sock->state == SS_UNCONNECTED) {
err = -ENOTCONN;
- if (sk->sk_type == SOCK_STREAM)
+ if (sock_type_connectible(sk->sk_type))
goto out;
} else {
sock->state = SS_DISCONNECTING;
@@ -960,7 +965,7 @@ static int vsock_shutdown(struct socket *sock, int mode)
sk->sk_shutdown |= mode;
sk->sk_state_change(sk);
- if (sk->sk_type == SOCK_STREAM) {
+ if (sock_type_connectible(sk->sk_type)) {
sock_reset_flag(sk, SOCK_DONE);
vsock_send_shutdown(sk, mode);
}
sock_put(sk);
}
-static int vsock_stream_connect(struct socket *sock, struct sockaddr *addr,
- int addr_len, int flags)
+static int vsock_connect(struct socket *sock, struct sockaddr *addr,
+ int addr_len, int flags)
{
int err;
struct sock *sk;
@@ -1413,7 +1418,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock, int flags,
lock_sock(listener);
- if (sock->type != SOCK_STREAM) {
+ if (!sock_type_connectible(sock->type)) {
err = -EOPNOTSUPP;
goto out;
}
@@ -1490,7 +1495,7 @@ static int vsock_listen(struct socket *sock, int backlog)
lock_sock(sk);
- if (sock->type != SOCK_STREAM) {
+ if (!sock_type_connectible(sk->sk_type)) {
err = -EOPNOTSUPP;
goto out;
}
vsk->buffer_size = val;
}
-static int vsock_stream_setsockopt(struct socket *sock,
- int level,
- int optname,
- sockptr_t optval,
- unsigned int optlen)
+static int vsock_connectible_setsockopt(struct socket *sock,
+ int level,
+ int optname,
+ sockptr_t optval,
+ unsigned int optlen)
{
int err;
struct sock *sk;
@@ -1616,10 +1621,10 @@ static int vsock_stream_setsockopt(struct socket *sock,
return err;
}
-static int vsock_stream_getsockopt(struct socket *sock,
- int level, int optname,
- char __user *optval,
- int __user *optlen)
+static int vsock_connectible_getsockopt(struct socket *sock,
+ int level, int optname,
+ char __user *optval,
+ int __user *optlen)
{
int err;
int len;
@@ -1687,8 +1692,8 @@ static int vsock_stream_getsockopt(struct socket *sock,
On Thu, Feb 18, 2021 at 08:36:03AM +0300, Arseny Krasnov wrote:
quoted
This prepares af_vsock.c for SEQPACKET support: some functions such
as setsockopt(), getsockopt(), connect(), recvmsg(), sendmsg() are
shared between both types of sockets, so rename them in general
manner.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 64 +++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 30 deletions(-)
IIRC I had already given my R-b to this patch. Please carry it over when
you post a new version.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
if (vsk->transport)
vsk->transport->release(vsk);
- else if (sk->sk_type == SOCK_STREAM)
+ else if (sock_type_connectible(sk->sk_type))
vsock_remove_sock(vsk);
sock_orphan(sk);
@@ -947,7 +952,7 @@ static int vsock_shutdown(struct socket *sock, int mode)
lock_sock(sk);
if (sock->state == SS_UNCONNECTED) {
err = -ENOTCONN;
- if (sk->sk_type == SOCK_STREAM)
+ if (sock_type_connectible(sk->sk_type))
goto out;
} else {
sock->state = SS_DISCONNECTING;
@@ -960,7 +965,7 @@ static int vsock_shutdown(struct socket *sock, int mode)
sk->sk_shutdown |= mode;
sk->sk_state_change(sk);
- if (sk->sk_type == SOCK_STREAM) {
+ if (sock_type_connectible(sk->sk_type)) {
sock_reset_flag(sk, SOCK_DONE);
vsock_send_shutdown(sk, mode);
}
sock_put(sk);
}
-static int vsock_stream_connect(struct socket *sock, struct sockaddr *addr,
- int addr_len, int flags)
+static int vsock_connect(struct socket *sock, struct sockaddr *addr,
+ int addr_len, int flags)
{
int err;
struct sock *sk;
@@ -1413,7 +1418,7 @@ static int vsock_accept(struct socket *sock, struct socket *newsock, int flags,
lock_sock(listener);
- if (sock->type != SOCK_STREAM) {
+ if (!sock_type_connectible(sock->type)) {
err = -EOPNOTSUPP;
goto out;
}
@@ -1490,7 +1495,7 @@ static int vsock_listen(struct socket *sock, int backlog)
lock_sock(sk);
- if (sock->type != SOCK_STREAM) {
+ if (!sock_type_connectible(sk->sk_type)) {
err = -EOPNOTSUPP;
goto out;
}
vsk->buffer_size = val;
}
-static int vsock_stream_setsockopt(struct socket *sock,
- int level,
- int optname,
- sockptr_t optval,
- unsigned int optlen)
+static int vsock_connectible_setsockopt(struct socket *sock,
+ int level,
+ int optname,
+ sockptr_t optval,
+ unsigned int optlen)
{
int err;
struct sock *sk;
@@ -1616,10 +1621,10 @@ static int vsock_stream_setsockopt(struct socket *sock,
return err;
}
-static int vsock_stream_getsockopt(struct socket *sock,
- int level, int optname,
- char __user *optval,
- int __user *optlen)
+static int vsock_connectible_getsockopt(struct socket *sock,
+ int level, int optname,
+ char __user *optval,
+ int __user *optlen)
{
int err;
int len;
@@ -1687,8 +1692,8 @@ static int vsock_stream_getsockopt(struct socket *sock,
On Mon, Feb 22, 2021 at 01:58:11PM +0300, Arseny Krasnov wrote:
On 22.02.2021 13:50, Stefano Garzarella wrote:
quoted
On Thu, Feb 18, 2021 at 08:36:03AM +0300, Arseny Krasnov wrote:
quoted
This prepares af_vsock.c for SEQPACKET support: some functions such
as setsockopt(), getsockopt(), connect(), recvmsg(), sendmsg() are
shared between both types of sockets, so rename them in general
manner.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 64 +++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 30 deletions(-)
IIRC I had already given my R-b to this patch. Please carry it over when
you post a new version.
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
Ack, sorry, didn't know that
Don't worry :-)
It is documented here: Documentation/process/submitting-patches.rst
Both Tested-by and Reviewed-by tags, once received on mailing list from tester
or reviewer, should be added by author to the applicable patches when sending
next versions. However if the patch has changed substantially in following
version, these tags might not be applicable anymore and thus should be removed.
Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
in the patch changelog (after the '---' separator).
Thanks,
Stefano
On Thu, Feb 18, 2021 at 08:36:33AM +0300, Arseny Krasnov wrote:
This moves wait loop for data to dedicated function, because later
it will be used by SEQPACKET data receive loop.
The patch LGTM, maybe just add a line in the commit message with
something like this:
While moving the code around, let's update an old comment.
Whit that fixed:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
On Thu, Feb 18, 2021 at 08:36:50AM +0300, Arseny Krasnov wrote:
This moves STREAM specific data receive logic to dedicated function:
'__vsock_stream_recvmsg()', while checks that will be same for both
types of socket are in shared function: 'vsock_connectible_recvmsg()'.
I'm not a native speaker, but I would rewrite this message like this:
Move STREAM specific data receive logic to '__vsock_stream_recvmsg()'
dedicated function, while checks, that will be same for both STREAM
and SEQPACKET sockets, stays in 'vsock_connectible_recvmsg()' shared
functions.
Anyway the patch LGTM:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
return data;
}
-static int
-vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
- int flags)
+static int __vsock_stream_recvmsg(struct sock *sk, struct msghdr *msg,
+ size_t len, int flags)
{
- struct sock *sk;
- struct vsock_sock *vsk;
+ struct vsock_transport_recv_notify_data recv_data;
const struct vsock_transport *transport;
- int err;
- size_t target;
+ struct vsock_sock *vsk;
ssize_t copied;
+ size_t target;
long timeout;
- struct vsock_transport_recv_notify_data recv_data;
+ int err;
DEFINE_WAIT(wait);
- sk = sock->sk;
vsk = vsock_sk(sk);
- err = 0;
-
- lock_sock(sk);
-
transport = vsk->transport;
- if (!transport || sk->sk_state != TCP_ESTABLISHED) {
- /* Recvmsg is supposed to return 0 if a peer performs an
- * orderly shutdown. Differentiate between that case and when a
- * peer has not connected or a local shutdown occured
with the
- * SOCK_DONE flag.
- */
- if (sock_flag(sk, SOCK_DONE))
- err = 0;
- else
- err = -ENOTCONN;
-
- goto out;
- }
-
- if (flags & MSG_OOB) {
- err = -EOPNOTSUPP;
- goto out;
- }
-
- /* We don't check peer_shutdown flag here since peer may actually shut
- * down, but there can be data in the queue that a local socket can
- * receive.
- */
- if (sk->sk_shutdown & RCV_SHUTDOWN) {
- err = 0;
- goto out;
- }
-
- /* It is valid on Linux to pass in a zero-length receive buffer. This
- * is not an error. We may as well bail out now.
- */
- if (!len) {
- err = 0;
- goto out;
- }
-
/* We must not copy less than target bytes into the user's buffer
* before returning successfully, so we wait for the consume queue to
* have that much data to consume before dequeueing. Note that this
if (copied > 0)
err = copied;
+out:
+ return err;
+}
+
+static int
+vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
+ int flags)
+{
+ struct sock *sk;
+ struct vsock_sock *vsk;
+ const struct vsock_transport *transport;
+ int err;
+
+ DEFINE_WAIT(wait);
+
+ sk = sock->sk;
+ vsk = vsock_sk(sk);
+ err = 0;
+
+ lock_sock(sk);
+
+ transport = vsk->transport;
+
+ if (!transport || sk->sk_state != TCP_ESTABLISHED) {
+ /* Recvmsg is supposed to return 0 if a peer performs an
+ * orderly shutdown. Differentiate between that case and
when a
+ * peer has not connected or a local shutdown occurred with the
+ * SOCK_DONE flag.
+ */
+ if (sock_flag(sk, SOCK_DONE))
+ err = 0;
+ else
+ err = -ENOTCONN;
+
+ goto out;
+ }
+
+ if (flags & MSG_OOB) {
+ err = -EOPNOTSUPP;
+ goto out;
+ }
+
+ /* We don't check peer_shutdown flag here since peer may actually shut
+ * down, but there can be data in the queue that a local socket can
+ * receive.
+ */
+ if (sk->sk_shutdown & RCV_SHUTDOWN) {
+ err = 0;
+ goto out;
+ }
+
+ /* It is valid on Linux to pass in a zero-length receive buffer. This
+ * is not an error. We may as well bail out now.
+ */
+ if (!len) {
+ err = 0;
+ goto out;
+ }
+
+ err = __vsock_stream_recvmsg(sk, msg, len, flags);
+
out:
release_sock(sk);
return err;
--
2.25.1
On Thu, Feb 18, 2021 at 08:37:15AM +0300, Arseny Krasnov wrote:
quoted hunk
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there is no sense for these values in SEQPACKET case.
3) It waits until whole record is received or error is found during
receiving.
4) It processes and sets 'MSG_TRUNC' flag.
So to avoid extra conditions for two types of socket inside one loop, two
independent functions were created.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 5 +++
net/vmw_vsock/af_vsock.c | 97 +++++++++++++++++++++++++++++++++++++++-
2 files changed, 101 insertions(+), 1 deletion(-)
I think this should be:
int (*seqpacket_dequeue)(struct vsock_sock *vsk, struct msghdr *msg,
int flags, bool *msg_ready);
To avoid:
$ ./scripts/checkpatch.pl --strict -g HEAD
CHECK: Alignment should match open parenthesis
#35: FILE: include/net/af_vsock.h:141:
+ int (*seqpacket_dequeue)(struct vsock_sock *vsk, struct msghdr *msg,
+ int flags, bool *msg_ready);
quoted hunk
+
/* Notification. */
int (*notify_poll_in)(struct vsock_sock *, size_t, bool *);
int (*notify_poll_out)(struct vsock_sock *, size_t, bool *);
return err;
}
+static int __vsock_seqpacket_recvmsg(struct sock *sk, struct msghdr *msg,
+ size_t len, int flags)
+{
+ const struct vsock_transport *transport;
+ const struct iovec *orig_iov;
+ unsigned long orig_nr_segs;
+ bool msg_ready;
+ struct vsock_sock *vsk;
+ size_t record_len;
+ long timeout;
+ int err = 0;
+ DEFINE_WAIT(wait);
+
+ vsk = vsock_sk(sk);
+ transport = vsk->transport;
+
+ timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
+ orig_nr_segs = msg->msg_iter.nr_segs;
+ orig_iov = msg->msg_iter.iov;
+ msg_ready = false;
+ record_len = 0;
+
+ while (1) {
+ err = vsock_wait_data(sk, &wait, timeout, NULL, 0);
+
+ if (err <= 0) {
+ /* In case of any loop break(timeout, signal
+ * interrupt or shutdown), we report user that
+ * nothing was copied.
+ */
+ err = 0;
+ break;
+ }
+
+ if (record_len == 0) {
+ record_len =
+ transport->seqpacket_seq_get_len(vsk);
+
+ if (record_len == 0)
+ continue;
+ }
+
+ err = transport->seqpacket_dequeue(vsk, msg,
+ flags, &msg_ready);
+
Sorry, I expressed myself wrong.
Here it's fine to avoid the blank line as in the previous version, by
single line I meant the seqpacket_dequeue() call, something like this:
err = transport->seqpacket_dequeue(vsk, msg, flags, &msg_ready);
if (err < 0) {
quoted hunk
+ if (err < 0) {
+ if (err == -EAGAIN) {
+ iov_iter_init(&msg->msg_iter, READ,
+ orig_iov, orig_nr_segs,
+ len);
+ /* Clear 'MSG_EOR' here, because dequeue
+ * callback above set it again if it was
+ * set by sender. This 'MSG_EOR' is from
+ * dropped record.
+ */
+ msg->msg_flags &= ~MSG_EOR;
+ record_len = 0;
+ continue;
+ }
+
+ err = -ENOMEM;
+ break;
+ }
+
+ if (msg_ready)
+ break;
+ }
+
+ if (sk->sk_err)
+ err = -sk->sk_err;
+ else if (sk->sk_shutdown & RCV_SHUTDOWN)
+ err = 0;
+
+ if (msg_ready) {
+ /* User sets MSG_TRUNC, so return real length of
+ * packet.
+ */
+ if (flags & MSG_TRUNC)
+ err = record_len;
+ else
+ err = len - msg->msg_iter.count;
+
+ /* Always set MSG_TRUNC if real length of packet is
+ * bigger than user's buffer.
+ */
+ if (record_len > len)
+ msg->msg_flags |= MSG_TRUNC;
+ }
+
+ return err;
+}
+
static int
vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
int flags)
On Thu, Feb 18, 2021 at 08:37:54AM +0300, Arseny Krasnov wrote:
quoted hunk
This moves loop that waits for space on send to separate function,
because it will be used for SEQ_BEGIN/SEQ_END sending before and
after data transmission. Waiting for SEQ_BEGIN/SEQ_END is needed
because such packets carries SEQPACKET header that couldn't be
fragmented by credit mechanism, so to avoid it, sender waits until
enough space will be ready.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 2 +
net/vmw_vsock/af_vsock.c | 99 +++++++++++++++++++++++++---------------
2 files changed, 63 insertions(+), 38 deletions(-)
/* Assign a transport to a socket and call the .init transport callback.
*
- * Note: for stream socket this must be called when vsk->remote_addr is set
- * (e.g. during the connect() or when a connection request on a listener
+ * Note: for connection oriented socket this must be called when vsk->remote_addr
+ * is set (e.g. during the connect() or when a connection request on a listener
* socket is received).
* The vsk->remote_addr is used to decide which transport to use:
* - remote CID == VMADDR_CID_LOCAL or g2h->local_cid or VMADDR_CID_HOST if
return 0;
/* transport->release() must be called with sock lock acquired.
- * This path can only be taken during vsock_stream_connect(),
- * where we have already held the sock lock.
- * In the other cases, this function is called on a new socket
- * which is not assigned to any transport.
+ * This path can only be taken during vsock_connect(), where we
+ * have already held the sock lock. In the other cases, this
+ * function is called on a new socket which is not assigned to
+ * any transport.
*/
vsk->transport->release(vsk);
vsock_deassign_transport(vsk);
@@ -658,9 +658,10 @@ static int __vsock_bind_connectible(struct vsock_sock *vsk,
vsock_addr_init(&vsk->local_addr, new_addr.svm_cid, new_addr.svm_port);
- /* Remove stream sockets from the unbound list and add them to the hash
- * table for easy lookup by its address. The unbound list is simply an
- * extra entry at the end of the hash table, a trick used by AF_UNIX.
+ /* Remove connection oriented sockets from the unbound list and add them
+ * to the hash table for easy lookup by its address. The unbound list
+ * is simply an extra entry at the end of the hash table, a trick used
+ * by AF_UNIX.
*/
__vsock_remove_bound(vsk);
__vsock_insert_bound(vsock_bound_sockets(&vsk->local_addr), vsk);
@@ -951,10 +952,10 @@ static int vsock_shutdown(struct socket *sock, int mode)
if ((mode & ~SHUTDOWN_MASK) || !mode)
return -EINVAL;
- /* If this is a STREAM socket and it is not connected then bail out
- * immediately. If it is a DGRAM socket then we must first kick the
- * socket so that it wakes up from any sleeping calls, for example
- * recv(), and then afterwards return the error.
+ /* If this is a connection oriented socket and it is not connected then
+ * bail out immediately. If it is a DGRAM socket then we must first
+ * kick the socket so that it wakes up from any sleeping calls, for
+ * example recv(), and then afterwards return the error.
*/
sk = sock->sk;
transport = vsk->transport;
- /* Callers should not provide a destination with stream sockets. */
+ /* Callers should not provide a destination with connection oriented
+ * sockets.
+ */
if (msg->msg_namelen) {
err = sk->sk_state == TCP_ESTABLISHED ? -EISCONN : -EOPNOTSUPP;
goto out;
--
2.25.1
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review the
rest. That part looks great to me, only found a few minor issues.
In the meantime, however, I'm getting a doubt, especially with regard to
other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because some
transports might not need to send markers.
But thinking about it more, they could actually implement stubs for that
calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of code,
unless someone has some objection.
Thanks,
Stefano
The title is a little cryptic, maybe a something like:
virtio/vsock: set packet's type in virtio_transport_send_pkt_info()
On Thu, Feb 18, 2021 at 08:39:02AM +0300, Arseny Krasnov wrote:
This moves passing type of packet from 'info' srtucture to send
Also here replace send with the function name.
function. There is no sense to set type of packet which differs
from type of socket, and since at current time only stream type
is supported, so force to use this type.
I'm not a native speaker, but I would rephrase a bit the commit message:
There is no need to set type of packet which differs from type of
socket. Since at current time only stream type is supported, set
it directly in virtio_transport_send_pkt_info(), so callers don't
need to set it.
On Thu, Feb 18, 2021 at 08:39:23AM +0300, Arseny Krasnov wrote:
quoted hunk
'virtio_transport_send_credit_update()' has some extra args:
1) 'type' may be set in 'virtio_transport_send_pkt_info()' using type
of socket.
2) This function is static and 'hdr' arg was always NULL.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/virtio_transport_common.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
}
EXPORT_SYMBOL_GPL(virtio_transport_put_credit);
-static int virtio_transport_send_credit_update(struct vsock_sock *vsk,
- int type,
- struct virtio_vsock_hdr *hdr)
+static int virtio_transport_send_credit_update(struct vsock_sock *vsk)
{
struct virtio_vsock_pkt_info info = {
.op = VIRTIO_VSOCK_OP_CREDIT_UPDATE,
- .type = type,
.vsk = vsk,
};
I don't know if it's better to remove type with the others changes in
the previous patch, maybe it's more consistent.
I mean only the removal of 'type' parameter, the 'hdr' parameter should
be removed with this patch.
* messages, we set the limit to a high value. TODO: experiment
* with different values.
*/
- if (free_space < VIRTIO_VSOCK_MAX_PKT_BUF_SIZE) {
- virtio_transport_send_credit_update(vsk,
-
VIRTIO_VSOCK_TYPE_STREAM,
- NULL);
- }
+ if (free_space < VIRTIO_VSOCK_MAX_PKT_BUF_SIZE)
+ virtio_transport_send_credit_update(vsk);
return total;
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
This patch LGTM, maybe we only need to change 'msg_cnt' as we discussed
on virtio-comment, but let's see if there are any other comments.
quoted hunk
diff --git a/include/linux/virtio_vsock.h
b/include/linux/virtio_vsock.h
index dc636b727179..003d06ae4a85 100644
VIRTIO_VSOCK_OP_CREDIT_UPDATE = 6,
/* Request the peer to send the credit info to us */
VIRTIO_VSOCK_OP_CREDIT_REQUEST = 7,
+
+ /* Record begin for SOCK_SEQPACKET */
+ VIRTIO_VSOCK_OP_SEQ_BEGIN = 8,
+ /* Record end for SOCK_SEQPACKET */
+ VIRTIO_VSOCK_OP_SEQ_END = 9,
};
/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
From: "Michael S. Tsirkin" <mst@redhat.com> Date: 2021-02-23 14:19:15
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
quoted hunk
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
@@ -83,6 +89,11 @@ enum virtio_vsock_op {VIRTIO_VSOCK_OP_CREDIT_UPDATE=6,/* Request the peer to send the credit info to us */VIRTIO_VSOCK_OP_CREDIT_REQUEST=7,++/* Record begin for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_BEGIN=8,+/* Record end for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_END=9,};/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
quoted
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review
the rest. That part looks great to me, only found a few minor issues.
I revieiwed the rest of it as well, left a few minor comments, but I
think we're well on track.
I'll take a better look at the specification patch tomorrow.
Thanks,
Stefano
In the meantime, however, I'm getting a doubt, especially with regard
to other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because
some transports might not need to send markers.
But thinking about it more, they could actually implement stubs for
that calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of
code, unless someone has some objection.
Thanks,
Stefano
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
quoted
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
quoted
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review
the rest. That part looks great to me, only found a few minor issues.
I revieiwed the rest of it as well, left a few minor comments, but I
think we're well on track.
I'll take a better look at the specification patch tomorrow.
Great, Thank You
Thanks,
Stefano
quoted
In the meantime, however, I'm getting a doubt, especially with regard
to other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because
some transports might not need to send markers.
But thinking about it more, they could actually implement stubs for
that calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of
code, unless someone has some objection.
I thought about that, I'll try to implement it in next version. Let's see...
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
quoted
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
@@ -83,6 +89,11 @@ enum virtio_vsock_op {VIRTIO_VSOCK_OP_CREDIT_UPDATE=6,/* Request the peer to send the credit info to us */VIRTIO_VSOCK_OP_CREDIT_REQUEST=7,++/* Record begin for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_BEGIN=8,+/* Record end for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_END=9,};/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
Probably a good idea to also have a feature bit gating
this functionality.
IIUC this also requires some qemu patch, because in current
implementation of vsock device in qemu, there is no 'set_features'
callback for such device. This callback will handle guest's write
to feature register, by calling vhost kernel backend, where this
bit will be processed by host.
IMHO I'm not sure that SEQPACKET support needs feature
bit - it is just two new ops for virtio vsock protocol, and from point
of view of virtio device it is same as STREAM. May be it is needed
for cases when client tries to connect to server which doesn't support
SEQPACKET, so without bit result will be "Connection reset by peer",
and with such bit client will know that server doesn't support it and
'socket(SOCK_SEQPACKET)' will return error?
From: "Michael S. Tsirkin" <mst@redhat.com> Date: 2021-02-24 06:44:12
On Wed, Feb 24, 2021 at 08:07:48AM +0300, Arseny Krasnov wrote:
On 23.02.2021 17:17, Michael S. Tsirkin wrote:
quoted
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
quoted
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
@@ -83,6 +89,11 @@ enum virtio_vsock_op {VIRTIO_VSOCK_OP_CREDIT_UPDATE=6,/* Request the peer to send the credit info to us */VIRTIO_VSOCK_OP_CREDIT_REQUEST=7,++/* Record begin for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_BEGIN=8,+/* Record end for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_END=9,};/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
Probably a good idea to also have a feature bit gating
this functionality.
IIUC this also requires some qemu patch, because in current
implementation of vsock device in qemu, there is no 'set_features'
callback for such device. This callback will handle guest's write
to feature register, by calling vhost kernel backend, where this
bit will be processed by host.
Well patching userspace to make use of a kernel feature
is par for the course, isn't it?
IMHO I'm not sure that SEQPACKET support needs feature
bit - it is just two new ops for virtio vsock protocol, and from point
of view of virtio device it is same as STREAM. May be it is needed
for cases when client tries to connect to server which doesn't support
SEQPACKET, so without bit result will be "Connection reset by peer",
and with such bit client will know that server doesn't support it and
'socket(SOCK_SEQPACKET)' will return error?
Yes, a better error handling would be one reason to do it like this.
--
MST
On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote:
On 23.02.2021 17:50, Stefano Garzarella wrote:
quoted
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
quoted
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
quoted
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review
the rest. That part looks great to me, only found a few minor issues.
I revieiwed the rest of it as well, left a few minor comments, but I
think we're well on track.
I'll take a better look at the specification patch tomorrow.
Great, Thank You
quoted
Thanks,
Stefano
quoted
In the meantime, however, I'm getting a doubt, especially with regard
to other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because
some transports might not need to send markers.
But thinking about it more, they could actually implement stubs for
that calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of
code, unless someone has some objection.
I thought about that, I'll try to implement it in next version. Let's see...
If you want to discuss it first, write down the idea you want to
implement, I wouldn't want to make you do unnecessary work. :-)
Cheers,
Stefano
On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote:
quoted
On 23.02.2021 17:50, Stefano Garzarella wrote:
quoted
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
quoted
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
quoted
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review
the rest. That part looks great to me, only found a few minor issues.
I revieiwed the rest of it as well, left a few minor comments, but I
think we're well on track.
I'll take a better look at the specification patch tomorrow.
Great, Thank You
quoted
Thanks,
Stefano
quoted
In the meantime, however, I'm getting a doubt, especially with regard
to other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because
some transports might not need to send markers.
But thinking about it more, they could actually implement stubs for
that calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of
code, unless someone has some objection.
I thought about that, I'll try to implement it in next version. Let's see...
If you want to discuss it first, write down the idea you want to
implement, I wouldn't want to make you do unnecessary work. :-)
Idea is simple, in iov iterator of 'struct msghdr' which is passed to
enqueue callback we have two fields: 'iov_offset' which is byte
offset inside io vector where next data must be picked and 'count'
which is rest of unprocessed bytes in io vector. So in seqpacket
enqueue callback if 'iov_offset' is 0 i'll send SEQBEGIN, and if
'count' is 0 i'll send SEQEND.
On Wed, Feb 24, 2021 at 01:41:56AM -0500, Michael S. Tsirkin wrote:
On Wed, Feb 24, 2021 at 08:07:48AM +0300, Arseny Krasnov wrote:
quoted
On 23.02.2021 17:17, Michael S. Tsirkin wrote:
quoted
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
quoted
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
@@ -83,6 +89,11 @@ enum virtio_vsock_op {VIRTIO_VSOCK_OP_CREDIT_UPDATE=6,/* Request the peer to send the credit info to us */VIRTIO_VSOCK_OP_CREDIT_REQUEST=7,++/* Record begin for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_BEGIN=8,+/* Record end for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_END=9,};/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
Probably a good idea to also have a feature bit gating
this functionality.
IIUC this also requires some qemu patch, because in current
implementation of vsock device in qemu, there is no 'set_features'
callback for such device. This callback will handle guest's write
to feature register, by calling vhost kernel backend, where this
bit will be processed by host.
Well patching userspace to make use of a kernel feature
is par for the course, isn't it?
quoted
IMHO I'm not sure that SEQPACKET support needs feature
bit - it is just two new ops for virtio vsock protocol, and from point
of view of virtio device it is same as STREAM. May be it is needed
for cases when client tries to connect to server which doesn't support
SEQPACKET, so without bit result will be "Connection reset by peer",
and with such bit client will know that server doesn't support it and
'socket(SOCK_SEQPACKET)' will return error?
Yes, a better error handling would be one reason to do it like this.
Agree, in this way we could implement a 'seqpacket_allow' callback
(similar to 'stream_allow'), and we can return 'true' if the feature is
negotiated.
So instead of checking all the seqpacket callbacks, we can use only this
callback to understand if the transport support it.
We can implement it also for other transports (vmci, hyperv) and return
always false for now.
Thanks,
Stefano
On Wed, Feb 24, 2021 at 11:28:50AM +0300, Arseny Krasnov wrote:
On 24.02.2021 11:23, Stefano Garzarella wrote:
quoted
On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote:
quoted
On 23.02.2021 17:50, Stefano Garzarella wrote:
quoted
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
quoted
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
quoted
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review
the rest. That part looks great to me, only found a few minor issues.
I revieiwed the rest of it as well, left a few minor comments, but I
think we're well on track.
I'll take a better look at the specification patch tomorrow.
Great, Thank You
quoted
Thanks,
Stefano
quoted
In the meantime, however, I'm getting a doubt, especially with regard
to other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because
some transports might not need to send markers.
But thinking about it more, they could actually implement stubs for
that calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of
code, unless someone has some objection.
I thought about that, I'll try to implement it in next version. Let's see...
If you want to discuss it first, write down the idea you want to
implement, I wouldn't want to make you do unnecessary work. :-)
Idea is simple, in iov iterator of 'struct msghdr' which is passed to
enqueue callback we have two fields: 'iov_offset' which is byte
offset inside io vector where next data must be picked and 'count'
which is rest of unprocessed bytes in io vector. So in seqpacket
enqueue callback if 'iov_offset' is 0 i'll send SEQBEGIN, and if
'count' is 0 i'll send SEQEND.
Got it, make sense and it's defently more transparent for the vsock
core!
Go head, maybe adding a comment in the vsock core explaining this, so
other developers can understand better if they want to support SEPACKET
in other transports.
Thanks,
Stefano
On Wed, Feb 24, 2021 at 11:28:50AM +0300, Arseny Krasnov wrote:
quoted
On 24.02.2021 11:23, Stefano Garzarella wrote:
quoted
On Wed, Feb 24, 2021 at 07:29:25AM +0300, Arseny Krasnov wrote:
quoted
On 23.02.2021 17:50, Stefano Garzarella wrote:
quoted
On Mon, Feb 22, 2021 at 03:23:11PM +0100, Stefano Garzarella wrote:
quoted
Hi Arseny,
On Thu, Feb 18, 2021 at 08:33:44AM +0300, Arseny Krasnov wrote:
quoted
This patchset impelements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of record
and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also,
both operations carries metadata - to maintain boundaries and payload
integrity. Metadata is introduced by adding special header with two
fields - message count and message length:
struct virtio_vsock_seq_hdr {
__le32 msg_cnt;
__le32 msg_len;
} __attribute__((packed));
This header is transmitted as payload of SEQ_BEGIN and SEQ_END
packets(buffer of second virtio descriptor in chain) in the same way as
data transmitted in RW packets. Payload was chosen as buffer for this
header to avoid touching first virtio buffer which carries header of
packet, because someone could check that size of this buffer is equal
to size of packet header. To send record, packet with start marker is
sent first(it's header contains length of record and counter), then
counter is incremented and all data is sent as usual 'RW' packets and
finally SEQ_END is sent(it also carries counter of message, which is
counter of SEQ_BEGIN + 1), also after sedning SEQ_END counter is
incremented again. On receiver's side, length of record is known from
packet with start record marker. To check that no packets were dropped
by transport, counters of two sequential SEQ_BEGIN and SEQ_END are
checked(counter of SEQ_END must be bigger that counter of SEQ_BEGIN by
1) and length of data between two markers is compared to length in
SEQ_BEGIN header.
Now as packets of one socket are not reordered neither on
vsock nor on vhost transport layers, such markers allows to restore
original record on receiver's side. If user's buffer is smaller that
record length, when all out of size data is dropped.
Maximum length of datagram is not limited as in stream socket,
because same credit logic is used. Difference with stream socket is
that user is not woken up until whole record is received or error
occurred. Implementation also supports 'MSG_EOR' and 'MSG_TRUNC' flags.
Tests also implemented.
I reviewed the first part (af_vsock.c changes), tomorrow I'll review
the rest. That part looks great to me, only found a few minor issues.
I revieiwed the rest of it as well, left a few minor comments, but I
think we're well on track.
I'll take a better look at the specification patch tomorrow.
Great, Thank You
quoted
Thanks,
Stefano
quoted
In the meantime, however, I'm getting a doubt, especially with regard
to other transports besides virtio.
Should we hide the begin/end marker sending in the transport?
I mean, should the transport just provide a seqpacket_enqueue()
callbacl?
Inside it then the transport will send the markers. This is because
some transports might not need to send markers.
But thinking about it more, they could actually implement stubs for
that calls, if they don't need to send markers.
So I think for now it's fine since it allows us to reuse a lot of
code, unless someone has some objection.
I thought about that, I'll try to implement it in next version. Let's see...
If you want to discuss it first, write down the idea you want to
implement, I wouldn't want to make you do unnecessary work. :-)
Idea is simple, in iov iterator of 'struct msghdr' which is passed to
enqueue callback we have two fields: 'iov_offset' which is byte
offset inside io vector where next data must be picked and 'count'
which is rest of unprocessed bytes in io vector. So in seqpacket
enqueue callback if 'iov_offset' is 0 i'll send SEQBEGIN, and if
'count' is 0 i'll send SEQEND.
Got it, make sense and it's defently more transparent for the vsock
core!
Go head, maybe adding a comment in the vsock core explaining this, so
other developers can understand better if they want to support SEPACKET
in other transports.
On 18 Feb 2021, at 06:36, Arseny Krasnov [off-list ref] wrote:
This moves wait loop for data to dedicated function, because later
it will be used by SEQPACKET data receive loop.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 155 +++++++++++++++++++++------------------
1 file changed, 83 insertions(+), 72 deletions(-)
In the original code, the prepare_to_wait() is called for each iteration of the while loop. In this
version, it is only called once. So if we do multiple iterations, the thread would be in the
TASK_RUNNING state, and subsequent schedule_timeout() will return immediately. So
looks like the prepare_to_wait() should be move here, in case we have a spurious wake_up.
quoted hunk
+ if (sk->sk_err != 0 ||
+ (sk->sk_shutdown & RCV_SHUTDOWN) ||
+ (vsk->peer_shutdown & SEND_SHUTDOWN)) {
+ break;
+ }
+
+ /* Don't wait for non-blocking sockets. */
+ if (timeout == 0) {
+ err = -EAGAIN;
+ break;
+ }
+
+ if (recv_data) {
+ err = transport->notify_recv_pre_block(vsk, target, recv_data);
+ if (err < 0)
+ break;
+ }
+
+ release_sock(sk);
+ timeout = schedule_timeout(timeout);
+ lock_sock(sk);
+
+ if (signal_pending(current)) {
+ err = sock_intr_errno(timeout);
+ break;
+ } else if (timeout == 0) {
+ err = -EAGAIN;
+ break;
+ }
+ }
+
+ finish_wait(sk_sleep(sk), wait);
+
+ if (err)
+ return err;
+
+ /* Internal transport error when checking for available
+ * data. XXX This should be changed to a connection
+ * reset in a later change.
+ */
+ if (data < 0)
+ return -ENOMEM;
+
+ return data;
+}
+
static int
vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
int flags)
On 18 Feb 2021, at 06:37, Arseny Krasnov [off-list ref] wrote:
quoted hunk
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there is no sense for these values in SEQPACKET case.
3) It waits until whole record is received or error is found during
receiving.
4) It processes and sets 'MSG_TRUNC' flag.
So to avoid extra conditions for two types of socket inside one loop, two
independent functions were created.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 5 +++
net/vmw_vsock/af_vsock.c | 97 +++++++++++++++++++++++++++++++++++++++-
2 files changed, 101 insertions(+), 1 deletion(-)
return err;
}
+static int __vsock_seqpacket_recvmsg(struct sock *sk, struct msghdr *msg,
+ size_t len, int flags)
+{
+ const struct vsock_transport *transport;
+ const struct iovec *orig_iov;
+ unsigned long orig_nr_segs;
+ bool msg_ready;
+ struct vsock_sock *vsk;
+ size_t record_len;
+ long timeout;
+ int err = 0;
+ DEFINE_WAIT(wait);
+
+ vsk = vsock_sk(sk);
+ transport = vsk->transport;
+
+ timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
+ orig_nr_segs = msg->msg_iter.nr_segs;
+ orig_iov = msg->msg_iter.iov;
+ msg_ready = false;
+ record_len = 0;
+
+ while (1) {
+ err = vsock_wait_data(sk, &wait, timeout, NULL, 0);
+
+ if (err <= 0) {
+ /* In case of any loop break(timeout, signal
+ * interrupt or shutdown), we report user that
+ * nothing was copied.
+ */
+ err = 0;
+ break;
+ }
+
+ if (record_len == 0) {
+ record_len =
+ transport->seqpacket_seq_get_len(vsk);
+
+ if (record_len == 0)
+ continue;
+ }
+
+ err = transport->seqpacket_dequeue(vsk, msg,
+ flags, &msg_ready);
+
+ if (err < 0) {
+ if (err == -EAGAIN) {
+ iov_iter_init(&msg->msg_iter, READ,
+ orig_iov, orig_nr_segs,
+ len);
+ /* Clear 'MSG_EOR' here, because dequeue
+ * callback above set it again if it was
+ * set by sender. This 'MSG_EOR' is from
+ * dropped record.
+ */
+ msg->msg_flags &= ~MSG_EOR;
+ record_len = 0;
+ continue;
+ }
So a question for my understanding of the flow here. SOCK_SEQPACKET is reliable, so
what does it mean to drop the record? Is the transport supposed to roll back to the
beginning of the current record? If the incoming data in the transport doesn’t follow
the protocol, and packets need to be dropped, shouldn’t the socket be reset or similar?
Maybe there is potential for simplifying the flow if that is the case.
quoted hunk
+
+ err = -ENOMEM;
+ break;
+ }
+
+ if (msg_ready)
+ break;
+ }
+
+ if (sk->sk_err)
+ err = -sk->sk_err;
+ else if (sk->sk_shutdown & RCV_SHUTDOWN)
+ err = 0;
+
+ if (msg_ready) {
+ /* User sets MSG_TRUNC, so return real length of
+ * packet.
+ */
+ if (flags & MSG_TRUNC)
+ err = record_len;
+ else
+ err = len - msg->msg_iter.count;
+
+ /* Always set MSG_TRUNC if real length of packet is
+ * bigger than user's buffer.
+ */
+ if (record_len > len)
+ msg->msg_flags |= MSG_TRUNC;
+ }
+
+ return err;
+}
+
static int
vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
int flags)
On 18 Feb 2021, at 06:37, Arseny Krasnov [off-list ref] wrote:
quoted
This adds receive loop for SEQPACKET. It looks like receive loop for
STREAM, but there is a little bit difference:
1) It doesn't call notify callbacks.
2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because
there is no sense for these values in SEQPACKET case.
3) It waits until whole record is received or error is found during
receiving.
4) It processes and sets 'MSG_TRUNC' flag.
So to avoid extra conditions for two types of socket inside one loop, two
independent functions were created.
Signed-off-by: Arseny Krasnov <redacted>
---
include/net/af_vsock.h | 5 +++
net/vmw_vsock/af_vsock.c | 97 +++++++++++++++++++++++++++++++++++++++-
2 files changed, 101 insertions(+), 1 deletion(-)
return err;
}
+static int __vsock_seqpacket_recvmsg(struct sock *sk, struct msghdr *msg,
+ size_t len, int flags)
+{
+ const struct vsock_transport *transport;
+ const struct iovec *orig_iov;
+ unsigned long orig_nr_segs;
+ bool msg_ready;
+ struct vsock_sock *vsk;
+ size_t record_len;
+ long timeout;
+ int err = 0;
+ DEFINE_WAIT(wait);
+
+ vsk = vsock_sk(sk);
+ transport = vsk->transport;
+
+ timeout = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
+ orig_nr_segs = msg->msg_iter.nr_segs;
+ orig_iov = msg->msg_iter.iov;
+ msg_ready = false;
+ record_len = 0;
+
+ while (1) {
+ err = vsock_wait_data(sk, &wait, timeout, NULL, 0);
+
+ if (err <= 0) {
+ /* In case of any loop break(timeout, signal
+ * interrupt or shutdown), we report user that
+ * nothing was copied.
+ */
+ err = 0;
+ break;
+ }
+
+ if (record_len == 0) {
+ record_len =
+ transport->seqpacket_seq_get_len(vsk);
+
+ if (record_len == 0)
+ continue;
+ }
+
+ err = transport->seqpacket_dequeue(vsk, msg,
+ flags, &msg_ready);
+
+ if (err < 0) {
+ if (err == -EAGAIN) {
+ iov_iter_init(&msg->msg_iter, READ,
+ orig_iov, orig_nr_segs,
+ len);
+ /* Clear 'MSG_EOR' here, because dequeue
+ * callback above set it again if it was
+ * set by sender. This 'MSG_EOR' is from
+ * dropped record.
+ */
+ msg->msg_flags &= ~MSG_EOR;
+ record_len = 0;
+ continue;
+ }
So a question for my understanding of the flow here. SOCK_SEQPACKET is reliable, so
what does it mean to drop the record? Is the transport supposed to roll back to the
beginning of the current record? If the incoming data in the transport doesn’t follow
the protocol, and packets need to be dropped, shouldn’t the socket be reset or similar?
Maybe there is potential for simplifying the flow if that is the case.
As vhost transport could drop some packets(for example when kmalloc failed),
in this case user will see part of record(when RW packet was dropped), or it will
be impossible to distinguish two records(when END of first and BEGIN of second
were missed). So in this case user continues to sleep and such orphaned packets
will be dropped.
Yes, it will simplify logic a lot, if i'll just send connection reset when invalid
sequence of packets were detected.
quoted
+
+ err = -ENOMEM;
+ break;
+ }
+
+ if (msg_ready)
+ break;
+ }
+
+ if (sk->sk_err)
+ err = -sk->sk_err;
+ else if (sk->sk_shutdown & RCV_SHUTDOWN)
+ err = 0;
+
+ if (msg_ready) {
+ /* User sets MSG_TRUNC, so return real length of
+ * packet.
+ */
+ if (flags & MSG_TRUNC)
+ err = record_len;
+ else
+ err = len - msg->msg_iter.count;
+
+ /* Always set MSG_TRUNC if real length of packet is
+ * bigger than user's buffer.
+ */
+ if (record_len > len)
+ msg->msg_flags |= MSG_TRUNC;
+ }
+
+ return err;
+}
+
static int
vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
int flags)
On 18 Feb 2021, at 06:36, Arseny Krasnov [off-list ref] wrote:
This moves wait loop for data to dedicated function, because later
it will be used by SEQPACKET data receive loop.
Signed-off-by: Arseny Krasnov <redacted>
---
net/vmw_vsock/af_vsock.c | 155 +++++++++++++++++++++------------------
1 file changed, 83 insertions(+), 72 deletions(-)
In the original code, the prepare_to_wait() is called for each iteration of the while loop. In this
version, it is only called once. So if we do multiple iterations, the thread would be in the
TASK_RUNNING state, and subsequent schedule_timeout() will return immediately. So
looks like the prepare_to_wait() should be move here, in case we have a spurious wake_up.
Thank you, i'll fix it
quoted
+ if (sk->sk_err != 0 ||
+ (sk->sk_shutdown & RCV_SHUTDOWN) ||
+ (vsk->peer_shutdown & SEND_SHUTDOWN)) {
+ break;
+ }
+
+ /* Don't wait for non-blocking sockets. */
+ if (timeout == 0) {
+ err = -EAGAIN;
+ break;
+ }
+
+ if (recv_data) {
+ err = transport->notify_recv_pre_block(vsk, target, recv_data);
+ if (err < 0)
+ break;
+ }
+
+ release_sock(sk);
+ timeout = schedule_timeout(timeout);
+ lock_sock(sk);
+
+ if (signal_pending(current)) {
+ err = sock_intr_errno(timeout);
+ break;
+ } else if (timeout == 0) {
+ err = -EAGAIN;
+ break;
+ }
+ }
+
+ finish_wait(sk_sleep(sk), wait);
+
+ if (err)
+ return err;
+
+ /* Internal transport error when checking for available
+ * data. XXX This should be changed to a connection
+ * reset in a later change.
+ */
+ if (data < 0)
+ return -ENOMEM;
+
+ return data;
+}
+
static int
vsock_connectible_recvmsg(struct socket *sock, struct msghdr *msg, size_t len,
int flags)
On Wed, Feb 24, 2021 at 08:07:48AM +0300, Arseny Krasnov wrote:
quoted
On 23.02.2021 17:17, Michael S. Tsirkin wrote:
quoted
On Thu, Feb 18, 2021 at 08:39:37AM +0300, Arseny Krasnov wrote:
quoted
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender, because if we wake up user and it leaves syscall,
nobody will send credit update for rest of record, and sender will wait
for next enter of read syscall at receiver's side. So if user buffer is
full, we just send credit update and drop data. If during copy SEQ_BEGIN
was found(and not all data was copied), copying is restarted by reset
user's iov iterator(previous unfinished data is dropped).
Signed-off-by: Arseny Krasnov <redacted>
---
include/linux/virtio_vsock.h | 10 +++
include/uapi/linux/virtio_vsock.h | 16 ++++
net/vmw_vsock/virtio_transport_common.c | 114 ++++++++++++++++++++++++
3 files changed, 140 insertions(+)
@@ -83,6 +89,11 @@ enum virtio_vsock_op {VIRTIO_VSOCK_OP_CREDIT_UPDATE=6,/* Request the peer to send the credit info to us */VIRTIO_VSOCK_OP_CREDIT_REQUEST=7,++/* Record begin for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_BEGIN=8,+/* Record end for SOCK_SEQPACKET */+VIRTIO_VSOCK_OP_SEQ_END=9,};/* VIRTIO_VSOCK_OP_SHUTDOWN flags values */
Probably a good idea to also have a feature bit gating
this functionality.
IIUC this also requires some qemu patch, because in current
implementation of vsock device in qemu, there is no 'set_features'
callback for such device. This callback will handle guest's write
to feature register, by calling vhost kernel backend, where this
bit will be processed by host.
Well patching userspace to make use of a kernel feature
is par for the course, isn't it?
quoted
IMHO I'm not sure that SEQPACKET support needs feature
bit - it is just two new ops for virtio vsock protocol, and from point
of view of virtio device it is same as STREAM. May be it is needed
for cases when client tries to connect to server which doesn't support
SEQPACKET, so without bit result will be "Connection reset by peer",
and with such bit client will know that server doesn't support it and
'socket(SOCK_SEQPACKET)' will return error?
Yes, a better error handling would be one reason to do it like this.
May be it will be better to add special flag to OP_RST. When someone
tries to connect to server which doesn't support such socket type(seqpacket
or dgram), connection reset is sent. This reset carries special flag which
indicates, that such socket type is not supported. Thus client will distinguish
cases when port listener is missed and socket type is not supported.
It will be easy to implement and qemu patch not needed.
From: Steven Rostedt <rostedt@goodmis.org> Date: 2021-03-02 23:35:32
On Thu, 18 Feb 2021 08:42:15 +0300
Arseny Krasnov [off-list ref] wrote:
Not sure if this was pulled in yet, but I do have a small issue with this
patch.
It's considered poor formatting to split strings like the above. This is
one of the exceptions for the 80 character limit. Do not break strings just
to keep it within 80 characters.
-- Steve
On Thu, 18 Feb 2021 08:42:15 +0300
Arseny Krasnov [off-list ref] wrote:
Not sure if this was pulled in yet, but I do have a small issue with this
patch.
It's considered poor formatting to split strings like the above. This is
one of the exceptions for the 80 character limit. Do not break strings just
to keep it within 80 characters.
-- Steve