RE: [PATCH net-next v3 0/5] lan743x speed boost
flat view
From: <Bryan.Whitehead@microchip.com>
Date: 2021-02-17 21:45:50
Also in:
lkml
From: Sven Van Asbroeck <redacted>
Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git #
9ec5eea5b6ac
v2 -> v3:
- Bryan Whitehead:
+ add Bryan's reviewed-by tag to patch 1/5.
+ Only use FRAME_LENGTH if the LS bit is checked.
If set use the smaller of FRAME_LENGTH or buffer length.
If clear use buffer length.
+ Correct typo in cover letter history (swap "packet" <-> "buffer").
v1 -> v2:
- Andrew Lunn:
+ always keep to Reverse Christmas Tree.
+ "changing the cache operations to operate on the received length"
should
go in its own, separate patch, so it can be easily backed out if
"interesting things" should happen with it.
- Bryan Whitehead:
+ multi-buffer patch concept "looks good".
As a result, I will squash the intermediate "dma buffer only" patch which
demonstrated the speed boost using an inflexible solution
(w/o multi-buffers).
+ Rename lan743x_rx_process_packet() to lan743x_rx_process_buffer()
+ Remove unused RX_PROCESS_RESULT_PACKET_DROPPED
+ Rename RX_PROCESS_RESULT_PACKET_RECEIVED to
RX_PROCESS_RESULT_BUFFER_RECEIVED
+ Fold "unmap from dma" into lan743x_rx_init_ring_element() to prevent
use-after-dma-unmap issue
+ ensure that skb allocation issues do not result in the driver sending
incomplete packets to the OS. E.g. a three-buffer packet, with the
middle buffer missing
- Willem De Bruyn: skb_hwtstamps(skb) always returns a non-null value, if
the
skb parameter points to a valid skb....
Sven Van Asbroeck (5): lan743x: boost performance on cpu archs w/o dma cache snooping lan743x: sync only the received area of an rx ring buffer TEST ONLY: lan743x: limit rx ring buffer size to 500 bytes TEST ONLY: lan743x: skb_alloc failure test TEST ONLY: lan743x: skb_trim failure test drivers/net/ethernet/microchip/lan743x_main.c | 352 +++++++++--------- drivers/net/ethernet/microchip/lan743x_main.h | 5 +- 2 files changed, 174 insertions(+), 183 deletions(-) -- 2.17.1
Hi Sven, Just to let you know, my colleague tested the patches 1 and 2 on x86 PC and we are satisfied with the result. We confirmed some performance improvements. We also confirmed PTP is working. Thanks for your work on this. Tested-by: UNGLinuxDriver@microchip.com