Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices
From: Kalle Valo <hidden>
Date: 2021-02-17 10:03:34
Also in:
linux-wireless, lkml
Srinivasan Raju [off-list ref] writes:
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM, x86 architectures and compiled in powerpc architecture. Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
I pushed this now to the pending branch of wireless-drivers-next for build testing, let's see what kind of results we get. I didn't manage to do a thorough review yet, but few quick comments:
quoted hunk
--- a/drivers/net/wireless/Kconfig +++ b/drivers/net/wireless/Kconfig@@ -35,6 +35,7 @@ source "drivers/net/wireless/st/Kconfig" source "drivers/net/wireless/ti/Kconfig" source "drivers/net/wireless/zydas/Kconfig" source "drivers/net/wireless/quantenna/Kconfig" +source "drivers/net/wireless/purelifi/Kconfig"
This is supposed to be in alphabetical order.
quoted hunk
--- a/drivers/net/wireless/Makefile +++ b/drivers/net/wireless/Makefile@@ -20,6 +20,7 @@ obj-$(CONFIG_WLAN_VENDOR_ST) += st/ obj-$(CONFIG_WLAN_VENDOR_TI) += ti/ obj-$(CONFIG_WLAN_VENDOR_ZYDAS) += zydas/ obj-$(CONFIG_WLAN_VENDOR_QUANTENNA) += quantenna/ +obj-$(CONFIG_WLAN_VENDOR_PURELIFI) += purelifi/
And this one as well. Clearly I missed these with quantenna, but no need to redo the same mistake with purelife. Also patches welcome to fix quantenna sorting.
quoted hunk
--- /dev/null +++ b/drivers/net/wireless/purelifi/plfxlc/Kconfig@@ -0,0 +1,13 @@ +# SPDX-License-Identifier: GPL-2.0-only +config PLFXLC + + tristate "pureLiFi X, XL, XC device support" + depends on CFG80211 && MAC80211 && USB + help + This driver makes the adapter appear as a normal WLAN interface. + + The pureLiFi device requires external STA firmware to be loaded. +
The documentation here is not telling much. I think it goes without saying that a firmware is needed, so no need to mention it. And also "normal WLAN interface" is a standard upstream requirement so drop that as well. Instead describe here in detail what hardware this driver supports, for example exact product names, bus types, wifi/ieee generation etc.
+ To compile this driver as a module, choose M here: the module will + be called purelifi.
Didn't you rename it to plfxlc? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches