Thread (3 messages) flat view 3 messages, 2 authors, 2021-02-15

Re: [PATCH net-next RFC v2] net: hdlc_x25: Queue outgoing LAPB frames

From: Xie He <hidden>
Date: 2021-02-15 07:01:27
Also in: lkml

On Sun, Feb 14, 2021 at 10:27 PM Martin Schiller [off-list ref] wrote:
At first glance, the patch looks quite reasonable. The only thing I
noticed right away is that you also included the changes of your patch
"Return meaningful error code in x25_open".
Thanks! It was because this patch was sent before that fix got merged
into "net-next". I will drop that part now.

I will also make the MTU of the virtual X.25 device be HDLC_MAX_MTU
(instead of HDLC_MAX_MTU - 2), because I see other HDLC Protocol
Drivers seem to also use this value as MTU (without subtracting the
header length).
I hope to get back to the office this week and test it.
Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help