Thread (2 messages) flat view 2 messages, 2 authors, 2021-02-14

[bug report] octeontx2-af: cn10k: Uninitialized variables

From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Date: 2021-02-12 18:40:22
Also in: lkml

Hi,

Variables cgx_id and lmac_id are being used uninitialized at lines 731
and 733 in the following function:

723 static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
724 {
725         struct mac_ops *mac_ops;
726         u8 cgx_id, lmac_id;
727
728         if (!is_cgx_config_permitted(rvu, pcifunc))
729                 return -EPERM;
730
731         mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
732
733         return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
734                                           lmac_id, en);
735 }

This bug was introduced by commit 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC internal loopback support")

What's the right solution for this?

Thanks
--
Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help