Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

On Fri, Feb 12, 2021 at 2:40 AM Min Li [off-list ref] wrote:

quoted

There should probably be a description of the purpose of the hardware both
here and in the patch description.

In particular, please explain how it relates to the existing clockmatrix driver.

I just uploaded v2 patch to provide more background info for this change.

It appears that you accidentally dropped the Cc list, adding them back in the
reply.  Also adding the PTP maintainer, as this clearly needs to be reviewed
in the context of the PTP subsystem. Please keep Richard and the netdev
list on Cc in future submissions.

This driver is developed to be only used by Renesas PTP Clock Manager for
Linux (pcm4l) software.

This driver supports 1588/PTP releated functionalities that
specific to Renesas devices but are not supported by general PHC framework.
So pcm4l will use both the existing PHC driver and this driver to complete
1588/PTP support.

Ah, so if this is for a PTP related driver, it should probably be integrated
into the PTP subsystem rather than being a separate class.

quoted

A pure list of register values seems neither particular portable nor intuitive.
How is a user expected to interpret these, and are you sure that any driver
for this class would have the same interpretation at the same register index?

Yes we need a way to dump register values when remote debugging with customers.
And all the Renesas SMU has similar register layout

A sysfs interface is a poor choice for this though -- how can you guarantee that
even future Renesas devices follow the exact same register layout? By
encoding the current hardware generation into the user interface, you
would end up having to emulate this on other chips you want to support later.

If it's only for debugging, best leave it out of the public interface, and only
have it in your own copy of the driver until the bugs are gone, or add a debugfs
interface.

quoted

Can you explain the purpose of this restriction? Why is it ok for two threads
to access the same file descriptor, but not two different file descriptors for
the same device?

The mutex is there to provide synchronization to the device access while PHC driver is accessing the device.
The atomic count is to make sure only one user space program is using the driver at a time.

Then remove the atomic count, as it clearly doesn't do what you describe
when you can have multiple threads access the driver concurrently.

quoted

Each of these needs a device tree binding. It's usually better to name the
compatible strings according to the chips that contain this hardware, such as
"renesas,r8a1234567-rsmucdev" instead of "renesas,rsmu-cdev0".

Since you don't seem to about the difference between the devices, the driver
can also just bind to one of them (usually the oldest) and then the newer
devices contain the string as a fallback, so you don't have to update the
driver every time another variant gets made.

Actually the device is not spawned from device tree but from Renesas MFD driver (submitted in a separate thread).
The MFD driver will call mfd_add_devices to create the platform devices. I am not sure if I still need to create binding
In this case.

If you have an of_device_id table, it needs a binding. It sounds like you
don't need the of_device_id though.

quoted

This should probably be part of the .c file, as no other driver needs to
interface with it.

We actually run a unit test on the driver that needs to access this structure.
That is why I need to put it in a header

Unit tests are good, but it's better to have them in the kernel.
Can you add the unit test into the patch then?
We now have the kunit framework for running unit tests.

quoted

This tells me that you got the abstraction the wrong way: the common files
should not need to know anything about the specific implementations.

Instead, these should be in separate modules that call exported functions
from the common code.

I got what you mean. But so far it only supports small set of functions, which is why
I don't feet it is worth the effort to over abstract things.

Then maybe pick one of the two hardware variants and drop the abstraction you
have. You can then add more features before you add a proper abstraction
layer and then the second driver.

            Arnd