Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

Hi,

Thanks for your comment.

On Thu, Feb 11, 2021 at 02:13:07PM -0800, David Miller wrote:

From: Nobuhiro Iwamatsu <redacted>
Date: Thu, 11 Feb 2021 01:29:52 +0900

quoted

+static int visconti_eth_init_hw(struct platform_device *pdev, struct plat_stmmacenet_data *plat_dat)
+{
+	struct visconti_eth *dwmac;
+	unsigned int reg_val, clk_sel_val;

Please use reverse christmas tree ordering for local variable declarations.

quoted

+static int visconti_eth_clock_probe(struct platform_device *pdev,
+				    struct plat_stmmacenet_data *plat_dat)
+{
+	int err;
+	struct visconti_eth *dwmac;

Likewise.

quoted

+static int visconti_eth_clock_remove(struct platform_device *pdev)
+{
+	struct net_device *ndev = platform_get_drvdata(pdev);
+	struct stmmac_priv *priv = netdev_priv(ndev);
+	struct visconti_eth *dwmac = get_stmmac_bsp_priv(&pdev->dev);

Likewise.

OK, I will fix these.

Best regards,
  Nobuhiro