Re: [PATCH] enetc: auto select PHYLIB and MDIO_DEVRES
From: Tong Zhang <hidden>
Date: 2021-02-11 18:31:28
Also in:
lkml
Thanks for the comments! I have sent a revised patch. - Tong On Thu, Feb 11, 2021 at 12:38 PM Florian Fainelli [off-list ref] wrote:
On 2/11/21 8:09 AM, Tong Zhang wrote:quoted
FSL_ENETC_MDIO use symbols from PHYLIB and MDIO_DEVRES, however they are not auto selected. ERROR: modpost: "__mdiobus_register" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! ERROR: modpost: "mdiobus_unregister" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! ERROR: modpost: "devm_mdiobus_alloc_size" [drivers/net/ethernet/freescale/enetc/fsl-enetc-mdio.ko] undefined! auto select MDIO_DEVRES and PHYLIB when FSL_ENETC_MDIO is selected.depends on MDIO_DEVRES && MDIO_BUS would be more appropriate because the symbols you reference are part of the MDIO bus layer, which happens to associated with PHYLIB depending on the configuration but as far as build goes you can separate the two. -- Florian