----------------------------------------------------------------------
On Thu, Feb 11, 2021 at 12:48:52PM +0200, stefanc@marvell.com wrote:

quoted

From: Stefan Chulski <redacted>

This patch add PPv23 version definition.
PPv23 is new packet processor in CP115.
Everything that supported by PPv22, also supported by PPv23.
No functional changes in this stage.

Signed-off-by: Stefan Chulski <redacted>
Acked-by: Marcin Wojtas <redacted>

Reviewed-by: Russell King <redacted>

quoted

@@ -7049,6 +7049,11 @@ static int mvpp2_probe(struct platform_device

*pdev)

quoted

 			priv->port_map |= BIT(i);
 	}

+	if (priv->hw_version != MVPP21) {
+		if (mvpp2_read(priv, MVPP2_VER_ID_REG) ==

MVPP2_VER_PP23)

quoted

+			priv->hw_version = MVPP23;
+	}
+

The only minor comment I have on this is... the formatting of the above.
Wouldn't:

	if (priv->hw_version >= MVPP22 &&
	    mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23)
		priv->hw_version = MVPP23;

read better?

Do we need to even check priv->hw_version here? Isn't this register
implemented in PPv2.1 where it contains the value zero?

Yes, we can just:
 	if (mvpp2_read(priv, MVPP2_VER_ID_REG) == MVPP2_VER_PP23)
 		priv->hw_version = MVPP23;

Thanks,
Stefan.