Thread (19 messages) 19 messages, 4 authors, 2021-02-09

Re: [PATCH 0/7] xen/events: bug fixes and some diagnostic aids

From: Julien Grall <hidden>
Date: 2021-02-08 10:54:57
Also in: linux-block, linux-scsi, lkml, stable, xen-devel

Hi Juergen,

On 08/02/2021 10:22, Jürgen Groß wrote:
On 08.02.21 10:54, Julien Grall wrote:
quoted
... I don't really see how the difference matter here. The idea is to 
re-use what's already existing rather than trying to re-invent the 
wheel with an extra lock (or whatever we can come up).
The difference is that the race is occurring _before_ any IRQ is
involved. So I don't see how modification of IRQ handling would help.
Roughly our current IRQ handling flow (handle_eoi_irq()) looks like:

if ( irq in progress )
{
   set IRQS_PENDING
   return;
}

do
{
   clear IRQS_PENDING
   handle_irq()
} while (IRQS_PENDING is set)

IRQ handling flow like handle_fasteoi_irq() looks like:

if ( irq in progress )
   return;

handle_irq()

The latter flow would catch "spurious" interrupt and ignore them. So it 
would handle nicely the race when changing the event affinity.

Cheers,

-- 
Julien Grall
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help