Re: [PATCH v1 2/2] mei: bus: change remove callback to return void
From: kernel test robot <hidden>
Date: 2021-02-08 00:18:23
Also in:
linux-watchdog, lkml, oe-kbuild-all
Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 5c8fe583cce542aa0b84adc939ce85293de36e5e] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551 base: 5c8fe583cce542aa0b84adc939ce85293de36e5e config: x86_64-randconfig-a001-20210208 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/a53f4d8c3937ee9db8a6f6335e6d562648f651f7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551 git checkout a53f4d8c3937ee9db8a6f6335e6d562648f651f7 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted> All errors (new ones prefixed by >>):
quoted
drivers/misc/mei/hdcp/mei_hdcp.c:860:56: error: expected ';' after expression
dev_warn(&cldev->dev, "mei_cldev_disable() failed\n")
^
;
1 error generated.
vim +860 drivers/misc/mei/hdcp/mei_hdcp.c
847
848 static void mei_hdcp_remove(struct mei_cl_device *cldev)
849 {
850 struct i915_hdcp_comp_master *comp_master =
851 mei_cldev_get_drvdata(cldev);
852 int ret;
853
854 component_master_del(&cldev->dev, &mei_component_master_ops);
855 kfree(comp_master);
856 mei_cldev_set_drvdata(cldev, NULL);
857
858 ret = mei_cldev_disable(cldev);
859 if (ret)
> 860 dev_warn(&cldev->dev, "mei_cldev_disable() failed\n")
861 }
862
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Attachments
- .config.gz [application/gzip] 30685 bytes