Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

On Fri, 5 Feb 2021 14:15:01 +0000 Hariprasad Kelam wrote:

quoted

quoted

Will add multi advertised mode support in near future.  

Looking at patch 6 it seems like the get side already supports multiple modes,
although the example output only lists supported no advertised.

Is the device actually doing IEEE autoneg or just configures the speed, lanes
etc. according to the link mode selected?  

Device supports IEEE autoneg mode. Agreed get_link_ksetting returns multiple modes .  
But set side  firmware code designed in such way that  it handles  single mode. Upon
Successful configuration firmware updates advertised modes to shared memory
 such that kernel will read and updates to ethtool.

It needs to be symmetric, get needs to reflect what set specified.