Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

Tue, Feb 02, 2021 at 02:04:45PM CET, oleksandr.mazur@plvision.eu wrote:

Add implementation for the port parameters
getting/setting.
Add bash completion for port param.
Add man description for port param.

Example:
$ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value false cmode runtime

$ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
netdevsim/netdevsim0/0:
 name test_port_parameter type driver-specific
   values:
     cmode runtime value false

$ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
{
   "param": {
       "netdevsim/netdevsim0/0": [ {
               "name": "test_port_parameter",
               "type": "driver-specific",
               "values": [ {
                       "cmode": "runtime",
                       "value": false
                   } ]
           } ]
   }
}

Signed-off-by: Oleksandr Mazur <redacted>

Looks fine.

Reviewed-by: Jiri Pirko <redacted>