Re: [PATCH] staging: qlge/qlge_main: Use min_t instead of min
From: Nathan Chancellor <nathan@kernel.org>
Date: 2021-02-04 22:59:30
Also in:
lkml
On Fri, Feb 05, 2021 at 03:24:51AM +0530, ameynarkhede02@gmail.com wrote:
quoted hunk ↗ jump to hunk
From: Amey Narkhede <redacted> Use min_t instead of min function in qlge/qlge_main.c Fixes following checkpatch.pl warning: WARNING: min() should probably be min_t(int, MAX_CPUS, num_online_cpus()) Signed-off-by: Amey Narkhede <redacted> --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 402edaeff..29606d1eb 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c@@ -3938,7 +3938,7 @@ static int ql_configure_rings(struct ql_adapter *qdev) int i; struct rx_ring *rx_ring; struct tx_ring *tx_ring; - int cpu_cnt = min(MAX_CPUS, (int)num_online_cpus()); + int cpu_cnt = min_t(int, MAX_CPUS, (int)num_online_cpus());
You should remove the cast on num_online_cpus() like checkpatch suggests. min_t adds the cast to int on both of the inputs for you.
/* In a perfect world we have one RSS ring for each CPU * and each has it's own vector. To do that we ask for -- 2.30.0
Cheers, Nathan