Re: [PATCH] net/qrtr: replaced useless kzalloc with kmalloc in qrtr_tun_write_iter()
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-04 18:54:36
Also in:
lkml
On Thu, 4 Feb 2021 15:02:30 +0600 Sabyrzhan Tasbolatov wrote:
Replaced kzalloc() with kmalloc(), there is no need for zeroed-out memory for simple void *kbuf.
There is no need for zeroed-out memory because it's immediately overwritten by copy_from_iter...
quoted hunk ↗ jump to hunk
quoted
For potential, separate clean up - this is followed by copy_from_iter_full(len) kzalloc() can probably be replaced by kmalloc()?quoted
if (!kbuf) return -ENOMEM;Signed-off-by: Sabyrzhan Tasbolatov <redacted> --- net/qrtr/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c index b238c40a9984..9b607c7614de 100644 --- a/net/qrtr/tun.c +++ b/net/qrtr/tun.c@@ -86,7 +86,7 @@ static ssize_t qrtr_tun_write_iter(struct kiocb *iocb, struct iov_iter *from) if (len > KMALLOC_MAX_SIZE) return -ENOMEM; - kbuf = kzalloc(len, GFP_KERNEL); + kbuf = kmalloc(len, GFP_KERNEL); if (!kbuf) return -ENOMEM;