[PATCH] rt2x00: remove duplicate word in comment

Subsystems: ralink rt2x00 wireless lan driver, the rest

STALE2039d

5 messages, 2 authors, 2021-02-04 · open the first message on its own page

[PATCH] rt2x00: remove duplicate word in comment

From: samirweng1979 <hidden>
Date: 2021-02-03 10:33:49

From: wengjianfeng <redacted>

remove duplicate word 'we' in comment

Signed-off-by: wengjianfeng <redacted>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
index c861811..7158152 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
@@ -179,7 +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 	 * Make room for new data. There are 2 possibilities
 	 * either the alignment is already present between
 	 * the 802.11 header and payload. In that case we
-	 * we have to move the header less then the iv_len
+	 * have to move the header less then the iv_len
 	 * since we can use the already available l2pad bytes
 	 * for the iv data.
 	 * When the alignment must be added manually we must
-- 
1.9.1

Re: [PATCH] rt2x00: remove duplicate word in comment

From: Randy Dunlap <rdunlap@infradead.org>
Date: 2021-02-03 15:19:54

On 2/2/21 10:38 PM, samirweng1979 wrote:
quoted hunk
From: wengjianfeng <redacted>

remove duplicate word 'we' in comment

Signed-off-by: wengjianfeng <redacted>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
index c861811..7158152 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
@@ -179,7 +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 	 * Make room for new data. There are 2 possibilities
 	 * either the alignment is already present between
 	 * the 802.11 header and payload. In that case we
-	 * we have to move the header less then the iv_len
+	 * have to move the header less then the iv_len
s/then/than/
 	 * since we can use the already available l2pad bytes
 	 * for the iv data.
 	 * When the alignment must be added manually we must

-- 
~Randy

Re: [PATCH] rt2x00: remove duplicate word in comment

From: Randy Dunlap <rdunlap@infradead.org>
Date: 2021-02-04 00:34:33

On 2/3/21 4:30 PM, wengjianfeng wrote:
On Wed, 3 Feb 2021 07:16:17 -0800
Randy Dunlap [off-list ref] wrote:
quoted
On 2/2/21 10:38 PM, samirweng1979 wrote:
quoted
From: wengjianfeng <redacted>

remove duplicate word 'we' in comment

Signed-off-by: wengjianfeng <redacted>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index
c861811..7158152 100644 ---
a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++
b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7
+179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 	 * Make room for new data. There are 2 possibilities
 	 * either the alignment is already present between
 	 * the 802.11 header and payload. In that case we
-	 * we have to move the header less then the iv_len
+	 * have to move the header less then the iv_len
s/then/than/
quoted
 	 * since we can use the already available l2pad bytes
 	 * for the iv data.
 	 * When the alignment must be added manually we must
Hi Randy,
   So you means add it for byte alignment, right? if yes,just ignore
   the patch. thanks.
No, I mean that there is a typo there also: "then" should be changed to "than"
while you are making changes.

thanks.
-- 
~Randy

Re: [PATCH] rt2x00: remove duplicate word in comment

From: wengjianfeng <hidden>
Date: 2021-02-04 03:08:43

On Wed, 3 Feb 2021 07:16:17 -0800
Randy Dunlap [off-list ref] wrote:
On 2/2/21 10:38 PM, samirweng1979 wrote:
quoted
From: wengjianfeng <redacted>

remove duplicate word 'we' in comment

Signed-off-by: wengjianfeng <redacted>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index
c861811..7158152 100644 ---
a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++
b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7
+179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 	 * Make room for new data. There are 2 possibilities
 	 * either the alignment is already present between
 	 * the 802.11 header and payload. In that case we
-	 * we have to move the header less then the iv_len
+	 * have to move the header less then the iv_len
s/then/than/
quoted
 	 * since we can use the already available l2pad bytes
 	 * for the iv data.
 	 * When the alignment must be added manually we must
Hi Randy,
   So you means add it for byte alignment, right? if yes,just ignore
   the patch. thanks.

Re: [PATCH] rt2x00: remove duplicate word in comment

From: wengjianfeng <hidden>
Date: 2021-02-04 04:43:42

On Wed, 3 Feb 2021 16:33:37 -0800
Randy Dunlap [off-list ref] wrote:
On 2/3/21 4:30 PM, wengjianfeng wrote:
quoted
On Wed, 3 Feb 2021 07:16:17 -0800
Randy Dunlap [off-list ref] wrote:
quoted
On 2/2/21 10:38 PM, samirweng1979 wrote:
quoted
From: wengjianfeng <redacted>

remove duplicate word 'we' in comment

Signed-off-by: wengjianfeng <redacted>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index
c861811..7158152 100644 ---
a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++
b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7
+179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 	 * Make room for new data. There are 2 possibilities
 	 * either the alignment is already present between
 	 * the 802.11 header and payload. In that case we
-	 * we have to move the header less then the iv_len
+	 * have to move the header less then the iv_len
s/then/than/
quoted
 	 * since we can use the already available l2pad bytes
 	 * for the iv data.
 	 * When the alignment must be added manually we must
Hi Randy,
   So you means add it for byte alignment, right? if yes,just ignore
   the patch. thanks.
No, I mean that there is a typo there also: "then" should be changed
to "than" while you are making changes.

thanks.
Hi Randy,
  Ok, I will update the patch,thanks for your reply.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help