Re: [PATCH 106/141] net: bridge: Fix fall-through warnings for Clang
From: Nikolay Aleksandrov <hidden>
Date: 2021-02-02 15:07:31
Also in:
bridge, linux-hardening, lkml
On 20/11/2020 20:37, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- net/bridge/br_input.c | 1 + 1 file changed, 1 insertion(+)diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c index 59a318b9f646..8db219d979c5 100644 --- a/net/bridge/br_input.c +++ b/net/bridge/br_input.c@@ -148,6 +148,7 @@ int br_handle_frame_finish(struct net *net, struct sock *sk, struct sk_buff *skb break; case BR_PKT_UNICAST: dst = br_fdb_find_rcu(br, eth_hdr(skb)->h_dest, vid); + break; default: break; }
Somehow this hasn't hit my inbox, good thing I just got the reply and saw the patch. Anyway, thanks! Acked-by: Nikolay Aleksandrov <redacted>