Re: [RFC net-next 1/2] net: dsa: add Realtek RTL8366S switch tag
From: Linus Walleij <hidden>
Date: 2021-02-27 23:48:19
On Wed, Feb 17, 2021 at 7:21 AM DENG Qingfang [off-list ref] wrote:
Add support for Realtek RTL8366S switch tag Signed-off-by: DENG Qingfang <dqfext@gmail.com>
I understand this switch tag now sorry for confusion.
quoted hunk ↗ jump to hunk
@@ -104,6 +104,12 @@ config NET_DSA_TAG_RTL4_A Realtek switches with 4 byte protocol A tags, sich as found in the Realtek RTL8366RB. +config NET_DSA_TAG_RTL8366S + tristate "Tag driver for Realtek RTL8366S switch tags" + help + Say Y or M if you want to enable support for tagging frames for the + Realtek RTL8366S switch.
I names the previous protocol "RTL4 A" after a 4-byte tag with protocol indicted as "A", what about naming this "RTL2 9" in the same vein? It will be good if some other switch is using the same protocol. (If any...)
obj-$(CONFIG_NET_DSA_TAG_RTL4_A) += tag_rtl4_a.o +obj-$(CONFIG_NET_DSA_TAG_RTL8366S) += tag_rtl8366s.o
So tag_rtl2_9.o etc. Yours, Linus Walleij