Re: [PATCH net] ethtool: fix the check logic of at least one channel for RX/TX

On Tue, Feb 23, 2021 at 05:02:06PM -0800, Jakub Kicinski wrote:

On Wed, 24 Feb 2021 01:32:51 +0100 Michal Kubecek wrote:

quoted

On Tue, Feb 23, 2021 at 02:24:40PM +0100, Simon Horman wrote:

quoted

From: Yinjun Zhang <redacted>

The command "ethtool -L <intf> combined 0" may clean the RX/TX channel
count and skip the error path, since the attrs
tb[ETHTOOL_A_CHANNELS_RX_COUNT] and tb[ETHTOOL_A_CHANNELS_TX_COUNT]
are NULL in this case when recent ethtool is used.

Tested using ethtool v5.10.

Fixes: 7be92514b99c ("ethtool: check if there is at least one channel for TX/RX in the core")
Signed-off-by: Yinjun Zhang <redacted>
Signed-off-by: Simon Horman <redacted>
Signed-off-by: Louis Peens <redacted>  

Reviewed-by: Michal Kubecek <redacted>

IOW you prefer this to what I proposed?

No, that was my misunderstanding, please see my reply to your e-mail.

Michal