Re: [PATCH net v3] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending

On Thu, Feb 18, 2021 at 11:06 PM Willem de Bruijn
[off-list ref] wrote:

On Thu, Feb 18, 2021 at 3:39 PM Jason A. Donenfeld [off-list ref] wrote:

quoted

The icmp{,v6}_send functions make all sorts of use of skb->cb, casting

Again, if respinning, please briefly describe the specific buggy code
path. I think it's informative and cannot be gleaned from the fix.

Ack.

quoted

-               send(skb, type, code, info, NULL);
+               send(skb, type, code, info, NULL, IP6CB(skb));

This should be parm.

Nice catch, thanks.

v4 coming up.