Re: HSR/PRP sequence counter issue with Cisco Redbox
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-02-17 19:52:01
From 8836f1df35a884327da37885ff3ad8bfc5eb933c Mon Sep 17 00:00:00 2001 From: Marco Wenzel <redacted> Date: Wed, 17 Feb 2021 13:53:31 +0100 Subject: [PATCH] net: hsr: add support for EntryForgetTime In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a node does not send any frame within this time, the sequence number check for can be ignored. This solves communication issues with Cisco IE 2000 in Redbox mode. Signed-off-by: Marco Wenzel <redacted>
It would be nice to have a Fixes: tag here to indicate which commit introduced the problem. If it has been broken forever, reference the commit which added HSR.
quoted hunk ↗ jump to hunk
diff --git a/net/hsr/hsr_framereg.h b/net/hsr/hsr_framereg.h index 86b43f539f2c..7a120ce3e3db 100644 --- a/net/hsr/hsr_framereg.h +++ b/net/hsr/hsr_framereg.h@@ -75,6 +75,7 @@ struct hsr_node { enum hsr_port_type addr_B_port; unsigned long time_in[HSR_PT_PORTS]; bool time_in_stale[HSR_PT_PORTS]; + unsigned long time_out[HSR_PT_PORTS];
It looks like the indentation is wrong here, and is using a mixture of
tabs and spaces.
Andrew