Re: [PATCH net-next] net: phy: icplus: Call phy_restore_page() when phy_select_page() fails
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2021-02-17 10:05:33
Also in:
kernel-janitors
On Wed, Feb 17, 2021 at 09:17:59AM +0300, Dan Carpenter wrote:
Smatch warns that there is a locking issue in this function: drivers/net/phy/icplus.c:273 ip101a_g_config_intr_pin() warn: inconsistent returns '&phydev->mdio.bus->mdio_lock'. Locked on : 242 Unlocked on: 273 It turns out that the comments in phy_select_page() say we have to call phy_restore_page() even if the call to phy_select_page() fails.
It seems it's a total waste of time documenting functions... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!