Thread (5 messages) flat view 5 messages, 3 authors, 2021-02-15

Re: [PATCH] ss: Make leading ":" always optional for sport and dport

From: David Ahern <hidden>
Date: 2021-02-15 05:13:51

On 2/14/21 1:09 AM, Thayne McCombs wrote:
Doh! Sorry about that, here it is with the sign-off.

-- >8 --
Don't put text here.
The sport and dport conditions in expressions were inconsistent on
whether there should be a ":" at the beginning of the port when only a
port was provided depending on the family. The link and netlink
families required a ":" to work. The vsock family required the ":"
to be absent. The inet and inet6 families work with or without a leading
":".

This makes the leading ":" optional in all cases, so if sport or dport
are used, then it works with a leading ":" or without one, as inet and
inet6 did.

Signed-off-by: Thayne McCombs <redacted>
---
put extra comments here
 misc/ss.c | 46 ++++++++++++++++++++++++----------------------
 1 file changed, 24 insertions(+), 22 deletions(-)
Also, put iproute2-next in the subject line along with a version number.

applied to iproute2-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help