Re: [PATCH net-next 3/5] net: bridge: propagate extack through switchdev_port_attr_set

Hi Nikolay,

On Sun, Feb 14, 2021 at 12:45:11PM +0200, Nikolay Aleksandrov wrote:

On 13/02/2021 22:43, Vladimir Oltean wrote:

quoted

From: Vladimir Oltean <vladimir.oltean@nxp.com>

The benefit is the ability to propagate errors from switchdev drivers
for the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING and
SWITCHDEV_ATTR_ID_BRIDGE_VLAN_PROTOCOL attributes.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 include/net/switchdev.h       |  3 ++-
 net/bridge/br_mrp_switchdev.c |  4 ++--
 net/bridge/br_multicast.c     |  6 +++---
 net/bridge/br_netlink.c       |  2 +-
 net/bridge/br_private.h       |  3 ++-
 net/bridge/br_stp.c           |  4 ++--
 net/bridge/br_switchdev.c     |  6 ++++--
 net/bridge/br_vlan.c          | 13 +++++++------
 net/switchdev/switchdev.c     | 19 ++++++++++++-------
 9 files changed, 35 insertions(+), 25 deletions(-)

You have to update the !CONFIG_NET_SWITCHDEV switchdev_port_attr_set() stub as well.

Thanks for pointing this out, you are right, the build fails.
What is really curious is that I had this issue on my radar but I forgot
to address it nonetheless.
I will take a step back and defer this series for after the break.