Re: [RFC PATCH 03/13] nexthop: Add netlink defines and enumerators for resilient NH groups
From: David Ahern <hidden>
Date: 2021-02-13 19:17:54
On 2/8/21 1:42 PM, Petr Machata wrote:
quoted hunk ↗ jump to hunk
@@ -52,8 +53,50 @@ enum { NHA_FDB, /* flag; nexthop belongs to a bridge fdb */ /* if NHA_FDB is added, OIF, BLACKHOLE, ENCAP cannot be set */ + /* nested; resilient nexthop group attributes */ + NHA_RES_GROUP, + /* nested; nexthop bucket attributes */ + NHA_RES_BUCKET, + __NHA_MAX, }; #define NHA_MAX (__NHA_MAX - 1) + +enum { + NHA_RES_GROUP_UNSPEC, + /* Pad attribute for 64-bit alignment. */ + NHA_RES_GROUP_PAD = NHA_RES_GROUP_UNSPEC, + + /* u32; number of nexthop buckets in a resilient nexthop group */ + NHA_RES_GROUP_BUCKETS,
u32 is overkill; arguably u16 (64k) should be more than enough buckets for any real use case.