Re: [PATCH net-next 2/2] tcp: factorize logic into tcp_epollin_ready()

On Sat, Feb 13, 2021 at 1:30 AM Wei Wang [off-list ref] wrote:

quoted

 void tcp_data_ready(struct sock *sk)
 {
-       const struct tcp_sock *tp = tcp_sk(sk);
-       int avail = tp->rcv_nxt - tp->copied_seq;
-
-       if (avail < sk->sk_rcvlowat && !tcp_rmem_pressure(sk) &&
-           !sock_flag(sk, SOCK_DONE) &&

Seems "!sock_flag(sk, SOCK_DONE)" is not checked in
tcp_epollin_read(). Does it matter?

Yes, probably, good catch.

Not sure where tcp_poll() gets this, I have to double check.

Thanks !