Re: [PATCH 0/4] Bug fixes to amd-xgbe driver
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-02-12 18:58:35
On 2/12/2021 10:00 AM, Shyam Sundar S K wrote:
General fixes on amd-xgbe driver are addressed in this series, mostly on the mailbox communication failures and improving the link stability of the amd-xgbe device. Shyam Sundar S K (4): amd-xgbe: Reset the PHY rx data path when mailbox command timeout amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning amd-xgbe: Reset link when the link never comes back amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP
If these are all bugfixes there would be an expectation that you provide appropriate Fixes: tag in your commit messages to designate which commit introduced the problem, you may also want to make it clear in the patch subject that this is intended for the "net" tree which collects bug fixes, see: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n28
drivers/net/ethernet/amd/xgbe/xgbe-common.h | 13 +++++++ drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 1 + drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 3 +- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 39 ++++++++++++++++++++- 4 files changed, 53 insertions(+), 3 deletions(-)
-- Florian