Re: [PATCH net] net: phy: consider that suspend2ram may cut off PHY power

On 11.02.2021 23:32, Heiner Kallweit wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Claudiu reported that on his system S2R cuts off power to the PHY and
after resuming certain PHY settings are lost. The PM folks confirmed
that cutting off power to selected components in S2R is a valid case.
Therefore resuming from S2R, same as from hibernation, has to assume
that the PHY has power-on defaults. As a consequence use the restore
callback also as resume callback.
In addition make sure that the interrupt configuration is restored.
Let's do this in phy_init_hw() and ensure that after this call
actual interrupt configuration is in sync with phydev->interrupts.
Currently, if interrupt was enabled before hibernation, we would
resume with interrupt disabled because that's the power-on default.

This fix applies cleanly only after the commit marked as fixed.

I don't have an affected system, therefore change is compile-tested
only.

[0] https://lore.kernel.org/netdev/1610120754-14331-1-git-send-email-claudiu.beznea@microchip.com/ (local)

Fixes: 611d779af7ca ("net: phy: fix MDIO bus PM PHY resuming")
Reported-by: Claudiu Beznea <redacted>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Hi Heiner,

I tested it on a system w/ SAMA7G5 and KSZ9131 PHY, with a S2R mode that
cuts the PHY's power and connectivity was good after resume. Thank you for
your patch!

Tested-by: Claudiu Beznea <redacted>