Re: [PATCH net] net: gro: do not keep too many GRO packets in napi->rx_list
From: Edward Cree <ecree.xilinx@gmail.com>
Date: 2021-02-05 23:18:03
On 04/02/2021 21:31, Eric Dumazet wrote:
From: Eric Dumazet <edumazet@google.com>
Commit c80794323e82 ("net: Fix packet reordering caused by GRO and
listified RX cooperation") had the unfortunate effect of adding
latencies in common workloads.
Before the patch, GRO packets were immediately passed to
upper stacks.
After the patch, we can accumulate quite a lot of GRO
packets (depdending on NAPI budget).
My fix is counting in napi->rx_count number of segments
instead of number of logical packets.
Fixes: c80794323e82 ("net: Fix packet reordering caused by GRO and listified RX cooperation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Bisected-by: John Sperbeck [off-list ref]
Tested-by: Jian Yang <redacted>
Cc: Maxim Mikityanskiy <redacted>
Cc: Alexander Lobakin <redacted>
Cc: Saeed Mahameed <redacted>
Cc: Edward Cree <redacted>Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>