Re: [PATCH net v2] net/sched: cls_flower: Reject invalid ct_state flags rules

On Thu, 4 Feb 2021 12:51:01 -0300 Marcelo Ricardo Leitner wrote:

On Thu, Feb 04, 2021 at 11:46:11PM +0800, wenxu@ucloud.cn wrote:

quoted

From: wenxu <redacted>

Reject the unsupported and invalid ct_state flags of cls flower rules.

Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info")
  

Hopefully Jakub can strip the blank line above.

Let's do one more spin, actually. Please remove this empty line between
tags wenxu.

quoted

+	if (state & ~TCA_FLOWER_KEY_CT_FLAGS_MASK) {
+		NL_SET_ERR_MSG_MOD(extack, "unsupported ct_state flags");
+		return -EINVAL;
+	}

For this check - can we use NLA_POLICY_MASK() please?

I wonder if we should use NL_SET_ERR_MSG_ATTR() for other checks.
Sadly there's no macro for both MOD and ATTR, and this is a fix,
but ATTR is probably far more informative than the module name so
I'd go with ATTR.