Thread (12 messages) flat view 12 messages, 2 authors, 2021-02-04

Re: [PATCH net-next 2/7] net: hns3: RSS indirection table and key use device specifications

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-04 00:51:50

On Tue, 2 Feb 2021 20:39:48 +0800 Huazhong Tan wrote:
 struct hclgevf_rss_cfg {
-	u8  rss_hash_key[HCLGEVF_RSS_KEY_SIZE]; /* user configured hash keys */
+	/* user configured hash keys */
+	u8  rss_hash_key[HCLGEVF_RSS_KEY_SIZE_MAX];
 	u32 hash_algo;
 	u32 rss_size;
 	u8 hw_tc_map;
-	u8  rss_indirection_tbl[HCLGEVF_RSS_IND_TBL_SIZE]; /* shadow table */
+	/* shadow table */
+	u8  rss_indirection_tbl[HCLGEVF_RSS_IND_TBL_SIZE_MAX];
 	struct hclgevf_rss_tuple_cfg rss_tuple_sets;
 };
What if the table sizes supported by the device grow beyond the
.._SIZE_MAX constants? Are you handling that case?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help