Thread (5 messages) flat view 5 messages, 3 authors, 2021-02-06

Re: [PATCH v2 2/2] ibmvnic: fix race with multiple open/close

From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2021-02-03 18:42:01

On Wed, Feb 3, 2021 at 12:10 AM Sukadev Bhattiprolu
[off-list ref] wrote:
If two or more instances of 'ip link set' commands race and first one
already brings the interface up (or down), the subsequent instances
can simply return without redoing the up/down operation.

Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Reported-by: Abdul Haleem <redacted>
Tested-by: Abdul Haleem <redacted>
Signed-off-by: Sukadev Bhattiprolu <redacted>

---
Changelog[v2] For consistency with ibmvnic_open() use "goto out" and return
              from end of function.
Did you find the code path that triggers this?

In v1 we discussed how the usual ip link path should not call the
driver twice based on IFF_UP.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help