Re: [PATCH net-next 5/6] i40e: Add info trace at loading XDP program
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-03 02:34:52
On Mon, 1 Feb 2021 18:24:19 -0800 Tony Nguyen wrote:
From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> New trace indicates that the XDP program was loaded. The trace has a note that in case of using XDP_REDIRECT, number of queues on both interfaces shall be the same. This is required for optimal performance of XDP_REDIRECT, if interface used for TX has lower number of queues than a RX interface, the packets may be dropped (depending on RSS queue assignment).
By RSS queue assignment you mean interrupt mapping?
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 521ea9df38d5..f35bd9164106 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c@@ -12489,11 +12489,14 @@ static int i40e_xdp_setup(struct i40e_vsi *vsi, /* Kick start the NAPI context if there is an AF_XDP socket open * on that queue id. This so that receiving will start. */ - if (need_reset && prog) + if (need_reset && prog) { + dev_info(&pf->pdev->dev, + "Loading XDP program, please note: XDP_REDIRECT action requires the same number of queues on both interfaces\n");
We try to avoid spamming logs. This message will be helpful to users only the first time, if at all.