Thread (20 messages) flat view 20 messages, 3 authors, 2021-02-04
STALE2027d REVIEWED: 1 (1M)

Revision v1 of 2 in this series; 1 review trailer (1 from subsystem maintainers).

Revisions (2)
  1. v1 current
  2. v2 [diff vs current]

[PATCH net-next 5/7] gtp: drop unnecessary call to skb_dst_drop

From: Jonas Bonn <hidden>
Date: 2021-02-02 06:53:51
Subsystem: gtp (gprs tunneling protocol), networking drivers, the rest · Maintainers: Pablo Neira Ayuso, Harald Welte, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

The call to skb_dst_drop() is already done as part of udp_tunnel_xmit().

Signed-off-by: Jonas Bonn <redacted>
Acked-by: Harald Welte <laforge@gnumonks.org>
---
 drivers/net/gtp.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index e4e57c0552ee..04d9de385549 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -515,8 +515,6 @@ static int gtp_build_skb_ip4(struct sk_buff *skb, struct net_device *dev,
 		goto err_rt;
 	}
 
-	skb_dst_drop(skb);
-
 	/* This is similar to tnl_update_pmtu(). */
 	df = iph->frag_off;
 	if (df) {
-- 
2.27.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help