From: Marc Kleine-Budde

Sent: 07 January 2021 21:17

On 1/7/21 8:06 PM, Jakub Kicinski wrote:

quoted

On Thu, 7 Jan 2021 11:00:35 -0800 Jakub Kicinski wrote:

quoted

On Thu,  7 Jan 2021 10:48:56 +0100 Marc Kleine-Budde wrote:

quoted

+struct __packed tcan4x5x_map_buf {
+	struct tcan4x5x_buf_cmd cmd;
+	u8 data[256 * sizeof(u32)];
+} ____cacheline_aligned;

Interesting attribute combo, I must say.

Looking at the rest of the patch I don't really see a reason for
__packed.  Perhaps it can be dropped?

It's the stream of bytes send via SPI to the chip. Here are both structs for
reference:

quoted

+struct __packed tcan4x5x_buf_cmd {
+	u8 cmd;
+	__be16 addr;
+	u8 len;
+};

This has to be packed, as I assume the compiler would add some space after the
"u8 cmd" to align the __be16 naturally.

Why not generate a series of 32bit words to be sent over the SPI bus.
Slightly less faffing in the code.
Then have a #define (or inline function) to merge the cmd+addr+len
into a single 32bit word.

Also if the length is in 32bit units, then the data[] field
ought to be u32[].

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)