Thread (4 messages) 4 messages, 3 authors, 2021-02-12

Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-01-29 20:10:23
Also in: bpf

On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote:
On 1/29/21 8:35 PM, Jakub Kicinski wrote:
quoted
kdoc didn't complain, and as you say it's already a mess, plus it's
two screen-fulls of scrolling away... 

I think converting to inline kdoc of members would be an improvement,
if you want to sign up for that? Otherwise -EDIDNTCARE on my side :)
  
What about removing this kdoc ?

kdoc for a huge structure is mostly useless...
It's definitely not useful for "us", I'd guess most seasoned developers
will just grep for uses of the field - but maybe it is useful for noobs
trying to have high-level sense of the code? 

Either way is fine by me, we can always preserve meaningful comments
inline without the kdoc decorator.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help