Re: [PATCH bpf-next] samples/bpf: add BPF_ATOMIC_OP macro for BPF samples

On 2021-01-18 11:57, Brendan Jackman wrote:

I actually deliberately skipped this file, thinking that people were
unlikely to want to add assembly-based atomics code under samples/

I guess it's nice for people to be able to e.g. move/copy code from
the selftests.

Yes, that, and the fact that one sample broke w/o the BPF_ATOMIC_OP.

On Mon, 18 Jan 2021 at 10:18, Björn Töpel [off-list ref] wrote:

quoted

From: Björn Töpel <redacted>

Brendan Jackman added extend atomic operations to the BPF instruction
set in commit 7064a7341a0d ("Merge branch 'Atomics for eBPF'"), which
introduces the BPF_ATOMIC_OP macro. However, that macro was missing
for the BPF samples. Fix that by adding it into bpf_insn.h.

Signed-off-by: Björn Töpel <redacted>

Reviewed-by: Brendan Jackman <redacted>

Thanks!
Björn