On Sat, Jan 23, 2021 at 12:52:21PM -0800, Jakub Kicinski wrote:

On Sat, 23 Jan 2021 19:59:00 +0800 Kevin Hao wrote:

quoted

+void *page_frag_alloc(struct page_frag_cache *nc,
+		      unsigned int fragsz, gfp_t gfp_mask)
+{
+	return page_frag_alloc_align(nc, fragsz, gfp_mask, 0);
+}
 EXPORT_SYMBOL(page_frag_alloc);

Isn't it better to make this a static inline now?

Sure. I will also inline the {netdev,napi}_alloc_frag().

Either way you'll need to repost after net is merged into net-next
(probably ~this Friday), please mark the posting as RFC before that.

Sorry, I missed that. I will repost after the net is merged into net-next.

Please make sure you CC the author of the code.

Will do.

Thanks,
Kevin