Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-01-31 00:40:37
Also in:
lkml
On Sat, Jan 30, 2021 at 09:43:34PM +0800, DENG Qingfang wrote:
Having multiple destination ports for a unicast address does not make
sense.
Make port_db_load_purge override existent unicast portvec instead of
adding a new port bit.
Fixes: 884729399260 ("net: dsa: mv88e6xxx: handle multiple ports in ATU")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Tobias has a point in a way too, you should get used to adding the 'master static' flags to your bridge fdb commands, otherwise weird things like this could happen. The faulty code can only be triggered when going through dsa_legacy_fdb_add, but it is still faulty nonetheless.