Thread (17 messages) flat view 17 messages, 5 authors, 2021-01-30

Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

From: Alexander Lobakin <hidden>
Date: 2021-01-30 16:21:23
Also in: intel-wired-lan, linux-mm, linux-rdma, lkml

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 29 Jan 2021 18:39:07 -0800
On Wed, 27 Jan 2021 20:11:23 +0000 Alexander Lobakin wrote:
quoted
+ * dev_page_is_reserved - check whether a page can be reused for network Rx
+ * @page: the page to test
+ *
+ * A page shouldn't be considered for reusing/recycling if it was allocated
+ * under memory pressure or at a distant memory node.
+ *
+ * Returns true if this page should be returned to page allocator, false
+ * otherwise.
+ */
+static inline bool dev_page_is_reserved(const struct page *page)
Am I the only one who feels like "reusable" is a better term than
"reserved".
I thought about it, but this will need to inverse the conditions in
most of the drivers. I decided to keep it as it is.
I can redo if "reusable" is preferred.

Regarding "no objectives to take patch 1 through net-next": patches
2-3 depend on it, so I can't put it in a separate series.

Thanks,
Al
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help