Re: [Patch v2 net-next 4/7] octeontx2-af: Physical link configuration support
flat view
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2021-01-27 20:35:15
Also in:
lkml
On Wed, Jan 27, 2021 at 4:02 AM Hariprasad Kelam [off-list ref] wrote:
From: Christina Jacob <redacted> CGX LMAC, the physical interface support link configuration parameters like speed, auto negotiation, duplex etc. Firmware saves these into memory region shared between firmware and this driver. This patch adds mailbox handler set_link_mode, fw_data_get to configure and read these parameters. Signed-off-by: Christina Jacob <redacted> Signed-off-by: Sunil Goutham <sgoutham@marvell.com> Signed-off-by: Hariprasad Kelam <redacted>
quoted hunk ↗ jump to hunk
+int rvu_mbox_handler_cgx_set_link_mode(struct rvu *rvu, + struct cgx_set_link_mode_req *req, + struct cgx_set_link_mode_rsp *rsp) +{ + int pf = rvu_get_pf(req->hdr.pcifunc); + u8 cgx_idx, lmac; + void *cgxd; + + if (!is_cgx_config_permitted(rvu, req->hdr.pcifunc)) + return -EPERM; + + rvu_get_cgx_lmac_id(rvu->pf2cgxlmac_map[pf], &cgx_idx, &lmac); + cgxd = rvu_cgx_pdata(cgx_idx, rvu); + rsp->status = cgx_set_link_mode(cgxd, req->args, cgx_idx, lmac);
nit: two spaces after assignment operator.
on the point of no new inline: do also check the status in patchwork.
that also flags such issues.